From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 16/20] xfs: merge xfs_bud_init into xfs_trans_get_bud
Date: Mon, 20 May 2019 09:13:26 -0400 [thread overview]
Message-ID: <20190520131326.GG31317@bfoster> (raw)
In-Reply-To: <20190517073119.30178-17-hch@lst.de>
On Fri, May 17, 2019 at 09:31:15AM +0200, Christoph Hellwig wrote:
> There is no good reason to keep these two functions separate.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_bmap_item.c | 14 ++++++--------
> fs/xfs/xfs_bmap_item.h | 2 --
> fs/xfs/xfs_trans_bmap.c | 16 ----------------
> 3 files changed, 6 insertions(+), 26 deletions(-)
>
> diff --git a/fs/xfs/xfs_bmap_item.c b/fs/xfs/xfs_bmap_item.c
> index 46dcadf790c2..40385c8b752a 100644
> --- a/fs/xfs/xfs_bmap_item.c
> +++ b/fs/xfs/xfs_bmap_item.c
> @@ -212,22 +212,20 @@ static const struct xfs_item_ops xfs_bud_item_ops = {
> .iop_release = xfs_bud_item_release,
> };
>
> -/*
> - * Allocate and initialize an bud item with the given number of extents.
> - */
> struct xfs_bud_log_item *
> -xfs_bud_init(
> - struct xfs_mount *mp,
> +xfs_trans_get_bud(
> + struct xfs_trans *tp,
> struct xfs_bui_log_item *buip)
> -
> {
> - struct xfs_bud_log_item *budp;
> + struct xfs_bud_log_item *budp;
>
> budp = kmem_zone_zalloc(xfs_bud_zone, KM_SLEEP);
> - xfs_log_item_init(mp, &budp->bud_item, XFS_LI_BUD, &xfs_bud_item_ops);
> + xfs_log_item_init(tp->t_mountp, &budp->bud_item, XFS_LI_BUD,
> + &xfs_bud_item_ops);
> budp->bud_buip = buip;
> budp->bud_format.bud_bui_id = buip->bui_format.bui_id;
>
> + xfs_trans_add_item(tp, &budp->bud_item);
> return budp;
> }
>
> diff --git a/fs/xfs/xfs_bmap_item.h b/fs/xfs/xfs_bmap_item.h
> index 89e043a88bb8..ad479cc73de8 100644
> --- a/fs/xfs/xfs_bmap_item.h
> +++ b/fs/xfs/xfs_bmap_item.h
> @@ -75,8 +75,6 @@ extern struct kmem_zone *xfs_bui_zone;
> extern struct kmem_zone *xfs_bud_zone;
>
> struct xfs_bui_log_item *xfs_bui_init(struct xfs_mount *);
> -struct xfs_bud_log_item *xfs_bud_init(struct xfs_mount *,
> - struct xfs_bui_log_item *);
> void xfs_bui_item_free(struct xfs_bui_log_item *);
> void xfs_bui_release(struct xfs_bui_log_item *);
> int xfs_bui_recover(struct xfs_trans *parent_tp, struct xfs_bui_log_item *buip);
> diff --git a/fs/xfs/xfs_trans_bmap.c b/fs/xfs/xfs_trans_bmap.c
> index e1c7d55b32c3..c6f5b217d17c 100644
> --- a/fs/xfs/xfs_trans_bmap.c
> +++ b/fs/xfs/xfs_trans_bmap.c
> @@ -18,22 +18,6 @@
> #include "xfs_bmap.h"
> #include "xfs_inode.h"
>
> -/*
> - * This routine is called to allocate a "bmap update done"
> - * log item.
> - */
> -struct xfs_bud_log_item *
> -xfs_trans_get_bud(
> - struct xfs_trans *tp,
> - struct xfs_bui_log_item *buip)
> -{
> - struct xfs_bud_log_item *budp;
> -
> - budp = xfs_bud_init(tp->t_mountp, buip);
> - xfs_trans_add_item(tp, &budp->bud_item);
> - return budp;
> -}
> -
> /*
> * Finish an bmap update and log it to the BUD. Note that the
> * transaction is marked dirty regardless of whether the bmap update
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-05-20 13:13 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 7:30 misc log item related cleanups Christoph Hellwig
2019-05-17 7:31 ` [PATCH 01/20] xfs: fix a trivial comment typo in the xfs_trans_committed_bulk Christoph Hellwig
2019-05-17 14:04 ` Brian Foster
2019-05-20 22:08 ` Darrick J. Wong
2019-05-17 7:31 ` [PATCH 02/20] xfs: stop using XFS_LI_ABORTED as a parameter flag Christoph Hellwig
2019-05-17 14:04 ` Brian Foster
2019-05-20 6:03 ` Christoph Hellwig
2019-05-17 14:10 ` Eric Sandeen
2019-05-20 6:05 ` Christoph Hellwig
2019-05-20 22:08 ` Darrick J. Wong
2019-06-11 8:46 ` Christoph Hellwig
2019-05-17 7:31 ` [PATCH 03/20] xfs: don't require log items to implement optional methods Christoph Hellwig
2019-05-17 14:06 ` Brian Foster
2019-05-20 6:06 ` Christoph Hellwig
2019-05-17 7:31 ` [PATCH 04/20] xfs: remove the dummy iop_push implementation for inode creation items Christoph Hellwig
2019-05-17 14:07 ` Brian Foster
2019-05-17 7:31 ` [PATCH 05/20] xfs: remove the iop_push implementation for quota off items Christoph Hellwig
2019-05-17 14:08 ` Brian Foster
2019-05-20 6:09 ` Christoph Hellwig
2019-05-17 7:31 ` [PATCH 06/20] xfs: don't use xfs_trans_free_items in the commit path Christoph Hellwig
2019-05-17 14:08 ` Brian Foster
2019-05-17 7:31 ` [PATCH 07/20] xfs: split iop_unlock Christoph Hellwig
2019-05-17 17:49 ` Brian Foster
2019-05-20 6:10 ` Christoph Hellwig
2019-05-20 11:38 ` Brian Foster
2019-05-17 7:31 ` [PATCH 08/20] xfs: add a flag to release log items on commit Christoph Hellwig
2019-05-17 17:50 ` Brian Foster
2019-05-20 6:11 ` Christoph Hellwig
2019-05-17 7:31 ` [PATCH 09/20] xfs: don't cast inode_log_items to get the log_item Christoph Hellwig
2019-05-17 17:50 ` Brian Foster
2019-05-17 7:31 ` [PATCH 10/20] xfs: remove the xfs_log_item_t typedef Christoph Hellwig
2019-05-17 17:50 ` Brian Foster
2019-05-17 7:31 ` [PATCH 11/20] xfs: use a list_head for iclog callbacks Christoph Hellwig
2019-05-20 13:12 ` Brian Foster
2019-05-20 13:19 ` Christoph Hellwig
2019-05-20 13:25 ` Brian Foster
2019-05-20 13:27 ` Bryan Gurney
2019-05-20 13:31 ` Christoph Hellwig
2019-05-17 7:31 ` [PATCH 12/20] xfs: remove a pointless comment duplicated above all xfs_item_ops instances Christoph Hellwig
2019-05-20 13:12 ` Brian Foster
2019-05-17 7:31 ` [PATCH 13/20] xfs: merge xfs_efd_init into xfs_trans_get_efd Christoph Hellwig
2019-05-17 8:16 ` Nikolay Borisov
2019-05-17 8:27 ` Christoph Hellwig
2019-05-17 18:26 ` Eric Sandeen
2019-05-20 6:03 ` Christoph Hellwig
2019-05-20 13:12 ` Brian Foster
2019-05-17 7:31 ` [PATCH 14/20] xfs: merge xfs_cud_init into xfs_trans_get_cud Christoph Hellwig
2019-05-20 13:13 ` Brian Foster
2019-05-17 7:31 ` [PATCH 15/20] xfs: merge xfs_rud_init into xfs_trans_get_rud Christoph Hellwig
2019-05-20 13:13 ` Brian Foster
2019-05-17 7:31 ` [PATCH 16/20] xfs: merge xfs_bud_init into xfs_trans_get_bud Christoph Hellwig
2019-05-20 13:13 ` Brian Foster [this message]
2019-05-17 7:31 ` [PATCH 17/20] xfs: merge xfs_trans_extfree.c into xfs_extfree_item.c Christoph Hellwig
2019-05-20 13:13 ` Brian Foster
2019-05-17 7:31 ` [PATCH 18/20] xfs: merge xfs_trans_refcount.c into xfs_refcount_item.c Christoph Hellwig
2019-05-20 13:14 ` Brian Foster
2019-05-17 7:31 ` [PATCH 19/20] xfs: merge xfs_trans_rmap.c into xfs_rmap_item.c Christoph Hellwig
2019-05-20 13:14 ` Brian Foster
2019-05-17 7:31 ` [PATCH 20/20] xfs: merge xfs_trans_bmap.c into xfs_bmap_item.c Christoph Hellwig
2019-05-20 13:14 ` Brian Foster
-- strict thread matches above, loose matches on Subject: below --
2019-06-13 18:02 misc log item related cleanups v2 Christoph Hellwig
2019-06-13 18:02 ` [PATCH 16/20] xfs: merge xfs_bud_init into xfs_trans_get_bud Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520131326.GG31317@bfoster \
--to=bfoster@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox