From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: remove unused flag arguments
Date: Mon, 20 May 2019 14:41:14 -0700 [thread overview]
Message-ID: <20190520214114.GN5352@magnolia> (raw)
In-Reply-To: <a0756ae7-eb4d-c25a-a567-d8d27301d12b@redhat.com>
On Mon, May 20, 2019 at 04:31:08PM -0500, Eric Sandeen wrote:
> On 5/20/19 4:21 PM, Darrick J. Wong wrote:
> > On Wed, May 15, 2019 at 01:37:32PM -0500, Eric Sandeen wrote:
> >> There are several functions which take a flag argument that is
> >> only ever passed as "0," so remove these arguments.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >> ---
> >>
> >> (motivated by simplifying userspace libxfs, TBH)
> >>
> >> libxfs/xfs_ag.c | 8 ++++----
> >> libxfs/xfs_alloc.c | 4 ++--
> >> libxfs/xfs_attr_remote.c | 2 +-
> >> libxfs/xfs_bmap.c | 14 +++++++-------
> >> libxfs/xfs_btree.c | 30 +++++++++++-------------------
> >> libxfs/xfs_btree.h | 10 +++-------
> >> libxfs/xfs_sb.c | 2 +-
> >> scrub/repair.c | 2 +-
> >> xfs_bmap_util.c | 6 +++---
> >> xfs_buf.h | 5 ++---
> >
> > Do you have an accompanying xfsprogs patch up your sleeve somewhere too?
> > :)
>
> yeah it's on the list, trying to decide if I want to wait and
> libxfs-merge this or just do it since IIRC it's kind of in the way
> of my other xfsprogs patches...
I'd prefer you wait so that we don't have xfsprogs out of sync with
kernel for a release.
--D
> -Eric
>
prev parent reply other threads:[~2019-05-20 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 18:37 [PATCH] xfs: remove unused flag arguments Eric Sandeen
2019-05-16 11:11 ` Brian Foster
2019-05-16 15:52 ` Bill O'Donnell
2019-05-16 16:59 ` Allison Collins
2019-05-20 21:21 ` Darrick J. Wong
2019-05-20 21:31 ` Eric Sandeen
2019-05-20 21:41 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520214114.GN5352@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox