From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 09/20] xfs: factor out iclog size calculation from xlog_sync
Date: Fri, 24 May 2019 09:25:11 +1000 [thread overview]
Message-ID: <20190523232511.GV29573@dread.disaster.area> (raw)
In-Reply-To: <20190523173742.15551-10-hch@lst.de>
On Thu, May 23, 2019 at 07:37:31PM +0200, Christoph Hellwig wrote:
> Split out another self-contained bit of code from xlog_sync.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_log.c | 64 ++++++++++++++++++++++++++++--------------------
> 1 file changed, 38 insertions(+), 26 deletions(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 885470f08554..e2c9f74f86f3 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1830,6 +1830,36 @@ xlog_split_iclog(
> return split_offset;
> }
>
> +static int
> +xlog_calc_iclog_size(
> + struct xlog *log,
> + struct xlog_in_core *iclog,
> + uint32_t *roundoff)
> +{
> + bool v2 = xfs_sb_version_haslogv2(&log->l_mp->m_sb);
> + uint32_t count_init, count;
> +
> + /* Add for LR header */
> + count_init = log->l_iclog_hsize + iclog->ic_offset;
> +
> + /* Round out the log write size */
> + if (v2 && log->l_mp->m_sb.sb_logsunit > 1) {
Hmmm, seeing as this is a now a standalone function, perhaps it
would make more sense to precalculate this whole check like so:
bool use_lsunit;
use_lsunit = xfs_sb_version_haslogv2(&log->l_mp->m_sb) &&
log->l_mp->m_sb.sb_logsunit > 1;
if (use_lsunit) {
> + /* we have a v2 stripe unit to use */
> + count = XLOG_LSUNITTOB(log, XLOG_BTOLSUNIT(log, count_init));
> + } else {
> + count = BBTOB(BTOBB(count_init));
> + }
Otherwise the patch looks good.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-05-23 23:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 17:37 use bios directly in the log code v2 Christoph Hellwig
2019-05-23 17:37 ` [PATCH 01/20] xfs: remove the no-op spinlock_destroy stub Christoph Hellwig
2019-05-23 22:31 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 02/20] xfs: remove the never used _XBF_COMPOUND flag Christoph Hellwig
2019-05-23 22:31 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 03/20] xfs: renumber XBF_WRITE_FAIL Christoph Hellwig
2019-05-23 22:32 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 04/20] xfs: make mem_to_page available outside of xfs_buf.c Christoph Hellwig
2019-05-23 22:33 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 05/20] xfs: reformat xlog_get_lowest_lsn Christoph Hellwig
2019-05-23 22:34 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 06/20] xfs: don't use REQ_PREFLUSH for split log writes Christoph Hellwig
2019-05-23 22:39 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 07/20] xfs: factor out log buffer writing from xlog_sync Christoph Hellwig
2019-05-23 23:04 ` Dave Chinner
2019-05-24 6:14 ` Christoph Hellwig
2019-05-23 17:37 ` [PATCH 08/20] xfs: factor out splitting of an iclog " Christoph Hellwig
2019-05-23 23:17 ` Dave Chinner
2019-05-24 6:16 ` Christoph Hellwig
2019-05-23 17:37 ` [PATCH 09/20] xfs: factor out iclog size calculation " Christoph Hellwig
2019-05-23 23:25 ` Dave Chinner [this message]
2019-05-23 17:37 ` [PATCH 10/20] xfs: update both stat counters together in xlog_sync Christoph Hellwig
2019-05-23 23:25 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 11/20] xfs: remove the syncing argument from xlog_verify_iclog Christoph Hellwig
2019-05-23 23:27 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 12/20] xfs: make use of the l_targ field in struct xlog Christoph Hellwig
2019-05-23 23:31 ` Dave Chinner
2019-05-23 17:37 ` [PATCH 13/20] xfs: use bios directly to write log buffers Christoph Hellwig
2019-05-23 17:37 ` [PATCH 14/20] xfs: move the log ioend workqueue to struct xlog Christoph Hellwig
2019-05-23 17:37 ` [PATCH 15/20] xfs: return an offset instead of a pointer from xlog_align Christoph Hellwig
2019-05-23 17:37 ` [PATCH 16/20] xfs: use bios directly to read and write the log recovery buffers Christoph Hellwig
2019-05-23 17:37 ` [PATCH 17/20] xfs: stop using bp naming for " Christoph Hellwig
2019-05-23 17:37 ` [PATCH 18/20] xfs: remove unused buffer cache APIs Christoph Hellwig
2019-05-23 17:37 ` [PATCH 19/20] xfs: properly type the b_log_item field in struct xfs_buf Christoph Hellwig
2019-05-23 17:37 ` [PATCH 20/20] xfs: remove the b_io_length " Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2019-06-03 17:29 use bios directly in the log code v2 Christoph Hellwig
2019-06-03 17:29 ` [PATCH 09/20] xfs: factor out iclog size calculation from xlog_sync Christoph Hellwig
2019-06-04 2:23 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523232511.GV29573@dread.disaster.area \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox