Re: [PATCH 04/11] xfs: bulkstat should copy lastip whenever userspace supplies one

Darrick J. Wong
2019-06-04T14:24:34Z

On Tue, Jun 04, 2019 at 05:54:42PM +1000, Dave Chinner wrote:
> On Wed, May 29, 2019 at 03:26:40PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > When userspace passes in a @lastip pointer we should copy the results
> > back, even if the @ocount pointer is NULL.
>
> Makes sense and the code change is simple enough, but this changes
> what we return to userspace, right? Does any of xfsprogs or fstests
> test code actually exercise this case? If not, how have you
> determined it isn't going to break anything?

Coming in a future xfstests submission along with other basic
functionality checks. :)

(Future, as in "later today"...)

--D

> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com