* [PATCH] include WARN, REPAIR build options in XFS_BUILD_OPTIONS
@ 2019-06-04 23:23 Eric Sandeen
2019-06-05 13:08 ` Bill O'Donnell
2019-06-05 15:13 ` Darrick J. Wong
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2019-06-04 23:23 UTC (permalink / raw)
To: linux-xfs
The XFS_BUILD_OPTIONS string, shown at module init time and
in modinfo output, does not currently include all available
build options. So, add in CONFIG_XFS_WARN and CONFIG_XFS_REPAIR.
It has been suggested in some quarters
That this is not enough.
Well ...
Anybody who would like to see this in a sysfs file can send
a patch. :)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
I might send that patch, but would like to have the string
advertising build options be complete, for now.
diff --git a/fs/xfs/xfs_super.h b/fs/xfs/xfs_super.h
index 21cb49a..763e43d 100644
--- a/fs/xfs/xfs_super.h
+++ b/fs/xfs/xfs_super.h
@@ -38,6 +38,18 @@
# define XFS_SCRUB_STRING
#endif
+#ifdef CONFIG_XFS_ONLINE_REPAIR
+# define XFS_REPAIR_STRING "repair, "
+#else
+# define XFS_REPAIR_STRING
+#endif
+
+#ifdef CONFIG_XFS_WARN
+# define XFS_WARN_STRING "verbose warnings, "
+#else
+# define XFS_WARN_STRING
+#endif
+
#ifdef DEBUG
# define XFS_DBG_STRING "debug"
#else
@@ -49,6 +61,8 @@
XFS_SECURITY_STRING \
XFS_REALTIME_STRING \
XFS_SCRUB_STRING \
+ XFS_REPAIR_STRING \
+ XFS_WARN_STRING \
XFS_DBG_STRING /* DBG must be last */
struct xfs_inode;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] include WARN, REPAIR build options in XFS_BUILD_OPTIONS
2019-06-04 23:23 [PATCH] include WARN, REPAIR build options in XFS_BUILD_OPTIONS Eric Sandeen
@ 2019-06-05 13:08 ` Bill O'Donnell
2019-06-05 15:13 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Bill O'Donnell @ 2019-06-05 13:08 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Tue, Jun 04, 2019 at 06:23:25PM -0500, Eric Sandeen wrote:
> The XFS_BUILD_OPTIONS string, shown at module init time and
> in modinfo output, does not currently include all available
> build options. So, add in CONFIG_XFS_WARN and CONFIG_XFS_REPAIR.
>
> It has been suggested in some quarters
> That this is not enough.
> Well ...
I saw what you did there ;)
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
>
> Anybody who would like to see this in a sysfs file can send
> a patch. :)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> I might send that patch, but would like to have the string
> advertising build options be complete, for now.
>
> diff --git a/fs/xfs/xfs_super.h b/fs/xfs/xfs_super.h
> index 21cb49a..763e43d 100644
> --- a/fs/xfs/xfs_super.h
> +++ b/fs/xfs/xfs_super.h
> @@ -38,6 +38,18 @@
> # define XFS_SCRUB_STRING
> #endif
>
> +#ifdef CONFIG_XFS_ONLINE_REPAIR
> +# define XFS_REPAIR_STRING "repair, "
> +#else
> +# define XFS_REPAIR_STRING
> +#endif
> +
> +#ifdef CONFIG_XFS_WARN
> +# define XFS_WARN_STRING "verbose warnings, "
> +#else
> +# define XFS_WARN_STRING
> +#endif
> +
> #ifdef DEBUG
> # define XFS_DBG_STRING "debug"
> #else
> @@ -49,6 +61,8 @@
> XFS_SECURITY_STRING \
> XFS_REALTIME_STRING \
> XFS_SCRUB_STRING \
> + XFS_REPAIR_STRING \
> + XFS_WARN_STRING \
> XFS_DBG_STRING /* DBG must be last */
>
> struct xfs_inode;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] include WARN, REPAIR build options in XFS_BUILD_OPTIONS
2019-06-04 23:23 [PATCH] include WARN, REPAIR build options in XFS_BUILD_OPTIONS Eric Sandeen
2019-06-05 13:08 ` Bill O'Donnell
@ 2019-06-05 15:13 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2019-06-05 15:13 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Tue, Jun 04, 2019 at 06:23:25PM -0500, Eric Sandeen wrote:
> The XFS_BUILD_OPTIONS string, shown at module init time and
> in modinfo output, does not currently include all available
> build options. So, add in CONFIG_XFS_WARN and CONFIG_XFS_REPAIR.
>
> It has been suggested in some quarters
> That this is not enough.
> Well ...
>
> Anybody who would like to see this in a sysfs file can send
> a patch. :)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> I might send that patch, but would like to have the string
> advertising build options be complete, for now.
>
Er, are you working on that patch now?
LGTM,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> diff --git a/fs/xfs/xfs_super.h b/fs/xfs/xfs_super.h
> index 21cb49a..763e43d 100644
> --- a/fs/xfs/xfs_super.h
> +++ b/fs/xfs/xfs_super.h
> @@ -38,6 +38,18 @@
> # define XFS_SCRUB_STRING
> #endif
>
> +#ifdef CONFIG_XFS_ONLINE_REPAIR
> +# define XFS_REPAIR_STRING "repair, "
> +#else
> +# define XFS_REPAIR_STRING
> +#endif
> +
> +#ifdef CONFIG_XFS_WARN
> +# define XFS_WARN_STRING "verbose warnings, "
> +#else
> +# define XFS_WARN_STRING
> +#endif
> +
> #ifdef DEBUG
> # define XFS_DBG_STRING "debug"
> #else
> @@ -49,6 +61,8 @@
> XFS_SECURITY_STRING \
> XFS_REALTIME_STRING \
> XFS_SCRUB_STRING \
> + XFS_REPAIR_STRING \
> + XFS_WARN_STRING \
> XFS_DBG_STRING /* DBG must be last */
>
> struct xfs_inode;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-05 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-04 23:23 [PATCH] include WARN, REPAIR build options in XFS_BUILD_OPTIONS Eric Sandeen
2019-06-05 13:08 ` Bill O'Donnell
2019-06-05 15:13 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox