From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:32800 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727601AbfFENIX (ORCPT ); Wed, 5 Jun 2019 09:08:23 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC39C3001809 for ; Wed, 5 Jun 2019 13:08:22 +0000 (UTC) Date: Wed, 5 Jun 2019 08:08:12 -0500 From: Bill O'Donnell Subject: Re: [PATCH] include WARN, REPAIR build options in XFS_BUILD_OPTIONS Message-ID: <20190605130812.GA9823@redhat.com> References: <15ed3957-d4f5-01a0-3d2e-d8a69cc435ce@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15ed3957-d4f5-01a0-3d2e-d8a69cc435ce@redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Sandeen Cc: linux-xfs On Tue, Jun 04, 2019 at 06:23:25PM -0500, Eric Sandeen wrote: > The XFS_BUILD_OPTIONS string, shown at module init time and > in modinfo output, does not currently include all available > build options. So, add in CONFIG_XFS_WARN and CONFIG_XFS_REPAIR. > > It has been suggested in some quarters > That this is not enough. > Well ... I saw what you did there ;) Reviewed-by: Bill O'Donnell > > Anybody who would like to see this in a sysfs file can send > a patch. :) > > Signed-off-by: Eric Sandeen > --- > > I might send that patch, but would like to have the string > advertising build options be complete, for now. > > diff --git a/fs/xfs/xfs_super.h b/fs/xfs/xfs_super.h > index 21cb49a..763e43d 100644 > --- a/fs/xfs/xfs_super.h > +++ b/fs/xfs/xfs_super.h > @@ -38,6 +38,18 @@ > # define XFS_SCRUB_STRING > #endif > > +#ifdef CONFIG_XFS_ONLINE_REPAIR > +# define XFS_REPAIR_STRING "repair, " > +#else > +# define XFS_REPAIR_STRING > +#endif > + > +#ifdef CONFIG_XFS_WARN > +# define XFS_WARN_STRING "verbose warnings, " > +#else > +# define XFS_WARN_STRING > +#endif > + > #ifdef DEBUG > # define XFS_DBG_STRING "debug" > #else > @@ -49,6 +61,8 @@ > XFS_SECURITY_STRING \ > XFS_REALTIME_STRING \ > XFS_SCRUB_STRING \ > + XFS_REPAIR_STRING \ > + XFS_WARN_STRING \ > XFS_DBG_STRING /* DBG must be last */ > > struct xfs_inode; >