From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 18/20] xfs: remove unused buffer cache APIs
Date: Thu, 6 Jun 2019 07:24:22 +1000 [thread overview]
Message-ID: <20190605212422.GE29573@dread.disaster.area> (raw)
In-Reply-To: <20190605151210.GB14846@lst.de>
On Wed, Jun 05, 2019 at 05:12:10PM +0200, Christoph Hellwig wrote:
> On Tue, Jun 04, 2019 at 04:24:42PM +1000, Dave Chinner wrote:
> > > @@ -1258,7 +1192,7 @@ xfs_buf_ioend_async(
> > > struct xfs_buf *bp)
> > > {
> > > INIT_WORK(&bp->b_ioend_work, xfs_buf_ioend_work);
> > > - queue_work(bp->b_ioend_wq, &bp->b_ioend_work);
> > > + queue_work(bp->b_target->bt_mount->m_buf_workqueue, &bp->b_ioend_work);
> > > }
> >
> > It'd be nice to keep bp->b_ioend_wq to avoid pointer chasing here.
> > Perhaps we could set it up in _xfs_buf_alloc() where we are pretty
> > much guaranteed to have the xfs_mount hot in cache, and then it's
> > set for the life of the buffer. Just a thought, but either way:
>
> We'd need to benchmark this particular case, but the bloat to
> the xfs_buf structure probably cancels out at least one pointer
> dereference. That being said we probably could at least remove
> one indirection without bloating the buf, I'll take a look at that.
FWIW, I already plan to move the buf workqueue to the xfs_buftarg
so maybe that's the way to go here...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-06-05 21:24 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 17:29 use bios directly in the log code v2 Christoph Hellwig
2019-06-03 17:29 ` [PATCH 01/20] xfs: remove the no-op spinlock_destroy stub Christoph Hellwig
2019-06-03 17:29 ` [PATCH 02/20] xfs: remove the never used _XBF_COMPOUND flag Christoph Hellwig
2019-06-03 17:29 ` [PATCH 03/20] xfs: renumber XBF_WRITE_FAIL Christoph Hellwig
2019-06-03 17:29 ` [PATCH 04/20] xfs: make mem_to_page available outside of xfs_buf.c Christoph Hellwig
2019-06-03 17:29 ` [PATCH 05/20] xfs: reformat xlog_get_lowest_lsn Christoph Hellwig
2019-06-03 17:29 ` [PATCH 06/20] xfs: don't use REQ_PREFLUSH for split log writes Christoph Hellwig
2019-06-04 16:12 ` Brian Foster
2019-06-04 22:45 ` Dave Chinner
2019-06-05 10:51 ` Brian Foster
2019-06-05 15:14 ` Christoph Hellwig
2019-06-05 15:47 ` Brian Foster
2019-06-03 17:29 ` [PATCH 07/20] xfs: factor out log buffer writing from xlog_sync Christoph Hellwig
2019-06-04 2:20 ` Dave Chinner
2019-06-03 17:29 ` [PATCH 08/20] xfs: factor out splitting of an iclog " Christoph Hellwig
2019-06-04 2:21 ` Dave Chinner
2019-06-03 17:29 ` [PATCH 09/20] xfs: factor out iclog size calculation " Christoph Hellwig
2019-06-04 2:23 ` Dave Chinner
2019-06-03 17:29 ` [PATCH 10/20] xfs: update both stat counters together in xlog_sync Christoph Hellwig
2019-06-03 17:29 ` [PATCH 11/20] xfs: remove the syncing argument from xlog_verify_iclog Christoph Hellwig
2019-06-03 17:29 ` [PATCH 12/20] xfs: make use of the l_targ field in struct xlog Christoph Hellwig
2019-06-03 17:29 ` [PATCH 13/20] xfs: use bios directly to write log buffers Christoph Hellwig
2019-06-04 5:54 ` Dave Chinner
2019-06-04 6:10 ` Christoph Hellwig
2019-06-03 17:29 ` [PATCH 14/20] xfs: move the log ioend workqueue to struct xlog Christoph Hellwig
2019-06-19 12:19 ` Christoph Hellwig
2019-06-19 22:51 ` Darrick J. Wong
2019-06-20 6:08 ` Christoph Hellwig
2019-06-03 17:29 ` [PATCH 15/20] xfs: return an offset instead of a pointer from xlog_align Christoph Hellwig
2019-06-03 17:29 ` [PATCH 16/20] xfs: use bios directly to read and write the log recovery buffers Christoph Hellwig
2019-06-04 6:13 ` Dave Chinner
2019-06-05 15:09 ` Christoph Hellwig
2019-06-03 17:29 ` [PATCH 17/20] xfs: stop using bp naming for " Christoph Hellwig
2019-06-04 6:19 ` Dave Chinner
2019-06-03 17:29 ` [PATCH 18/20] xfs: remove unused buffer cache APIs Christoph Hellwig
2019-06-04 6:24 ` Dave Chinner
2019-06-05 15:12 ` Christoph Hellwig
2019-06-05 21:24 ` Dave Chinner [this message]
2019-06-03 17:29 ` [PATCH 19/20] xfs: properly type the b_log_item field in struct xfs_buf Christoph Hellwig
2019-06-04 6:25 ` Dave Chinner
2019-06-03 17:29 ` [PATCH 20/20] xfs: remove the b_io_length " Christoph Hellwig
2019-06-04 6:27 ` Dave Chinner
2019-06-03 17:35 ` use bios directly in the log code v2 Darrick J. Wong
2019-06-03 17:38 ` Christoph Hellwig
2019-06-04 17:25 ` Darrick J. Wong
2019-06-04 17:54 ` Christoph Hellwig
2019-06-04 18:42 ` Brian Foster
2019-06-04 18:58 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2019-05-23 17:37 Christoph Hellwig
2019-05-23 17:37 ` [PATCH 18/20] xfs: remove unused buffer cache APIs Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605212422.GE29573@dread.disaster.area \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox