From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] Documentation: xfs: Fix typo
Date: Fri, 7 Jun 2019 11:34:10 -0700 [thread overview]
Message-ID: <20190607183410.GF1871505@magnolia> (raw)
In-Reply-To: <20190607114415.32cb32dd@lwn.net>
On Fri, Jun 07, 2019 at 11:44:15AM -0600, Jonathan Corbet wrote:
> On Thu, 9 May 2019 11:05:49 +0800
> Shiyang Ruan <ruansy.fnst@cn.fujitsu.com> wrote:
>
> > In "Y+P" of this line, there are two non-ASCII characters(0xd9 0x8d)
> > following behind the 'Y'. Shown as a small '=' under the '+' in VIM
> > and a '賺' in webpage[1].
> >
> > I think it's a mistake and remove these strange characters.
> >
> > [1]: https://www.kernel.org/doc/Documentation/filesystems/xfs-delayed-logging-design.txt
> >
> > Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
> > ---
> > Documentation/filesystems/xfs-delayed-logging-design.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/filesystems/xfs-delayed-logging-design.txt b/Documentation/filesystems/xfs-delayed-logging-design.txt
> > index 2ce36439c09f..9a6dd289b17b 100644
> > --- a/Documentation/filesystems/xfs-delayed-logging-design.txt
> > +++ b/Documentation/filesystems/xfs-delayed-logging-design.txt
> > @@ -34,7 +34,7 @@ transaction:
> > D A+B+C+D X+n+m+o
> > <object written to disk>
> > E E Y (> X+n+m+o)
> > - F E+F Yٍ+p
> > + F E+F Y+p
>
> OK, that does look funky, applied.
>
> This patch probably should have been copied to the XFS list (added), even
> though get_maintainer.pl doesn't know that.
Yeah, it's "Y+p" not "Y<weird plusequals thing>p" in the xfs
documentation repo:
https://git.kernel.org/pub/scm/fs/xfs/xfs-documentation.git/tree/design/XFS_Filesystem_Structure/delayed_logging.asciidoc
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
I doubt the value of maintaining duplicate copies of this document in
the kernel and the xfs documentation repo, and since the xfs docs and
kernel licences aren't compatible maybe we should withdraw one...
...but since Dave is the author I'm gonna punt to him. IMHO either we
should claim responsibility for those files in MAINTAINERS or drop them.
:)
Thanks for the heads-up,
--D
> Thanks,
>
> jon
next prev parent reply other threads:[~2019-06-07 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190509030549.2253-1-ruansy.fnst@cn.fujitsu.com>
2019-06-07 17:44 ` [PATCH] Documentation: xfs: Fix typo Jonathan Corbet
2019-06-07 18:34 ` Darrick J. Wong [this message]
2019-06-07 19:30 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607183410.GF1871505@magnolia \
--to=darrick.wong@oracle.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ruansy.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox