From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 02/20] xfs: stop using XFS_LI_ABORTED as a parameter flag
Date: Tue, 11 Jun 2019 10:46:46 +0200 [thread overview]
Message-ID: <20190611084646.GA22981@infradead.org> (raw)
In-Reply-To: <20190520220844.GD5335@magnolia>
On Mon, May 20, 2019 at 03:08:44PM -0700, Darrick J. Wong wrote:
> > -xlog_state_do_callback(
> > - struct xlog *log,
> > - int aborted,
> > - struct xlog_in_core *iclog);
> > +STATIC void xlog_state_done_syncing(
> > + struct xlog_in_core *iclog,
> > + bool aborted);
>
> I totally mistook this for a function definition. :/
>
> STATIC void xlog_state_done_syncing(struct xlog_in_core *iclog, bool aborted);
>
> ...seems to fit on one line, right?
Yes, but this style is used by all the forward declarations in
xfs_log.c. Eventually we should fix them all, or even better get rid
of most of them.
next prev parent reply other threads:[~2019-06-11 8:46 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 7:30 misc log item related cleanups Christoph Hellwig
2019-05-17 7:31 ` [PATCH 01/20] xfs: fix a trivial comment typo in the xfs_trans_committed_bulk Christoph Hellwig
2019-05-17 14:04 ` Brian Foster
2019-05-20 22:08 ` Darrick J. Wong
2019-05-17 7:31 ` [PATCH 02/20] xfs: stop using XFS_LI_ABORTED as a parameter flag Christoph Hellwig
2019-05-17 14:04 ` Brian Foster
2019-05-20 6:03 ` Christoph Hellwig
2019-05-17 14:10 ` Eric Sandeen
2019-05-20 6:05 ` Christoph Hellwig
2019-05-20 22:08 ` Darrick J. Wong
2019-06-11 8:46 ` Christoph Hellwig [this message]
2019-05-17 7:31 ` [PATCH 03/20] xfs: don't require log items to implement optional methods Christoph Hellwig
2019-05-17 14:06 ` Brian Foster
2019-05-20 6:06 ` Christoph Hellwig
2019-05-17 7:31 ` [PATCH 04/20] xfs: remove the dummy iop_push implementation for inode creation items Christoph Hellwig
2019-05-17 14:07 ` Brian Foster
2019-05-17 7:31 ` [PATCH 05/20] xfs: remove the iop_push implementation for quota off items Christoph Hellwig
2019-05-17 14:08 ` Brian Foster
2019-05-20 6:09 ` Christoph Hellwig
2019-05-17 7:31 ` [PATCH 06/20] xfs: don't use xfs_trans_free_items in the commit path Christoph Hellwig
2019-05-17 14:08 ` Brian Foster
2019-05-17 7:31 ` [PATCH 07/20] xfs: split iop_unlock Christoph Hellwig
2019-05-17 17:49 ` Brian Foster
2019-05-20 6:10 ` Christoph Hellwig
2019-05-20 11:38 ` Brian Foster
2019-05-17 7:31 ` [PATCH 08/20] xfs: add a flag to release log items on commit Christoph Hellwig
2019-05-17 17:50 ` Brian Foster
2019-05-20 6:11 ` Christoph Hellwig
2019-05-17 7:31 ` [PATCH 09/20] xfs: don't cast inode_log_items to get the log_item Christoph Hellwig
2019-05-17 17:50 ` Brian Foster
2019-05-17 7:31 ` [PATCH 10/20] xfs: remove the xfs_log_item_t typedef Christoph Hellwig
2019-05-17 17:50 ` Brian Foster
2019-05-17 7:31 ` [PATCH 11/20] xfs: use a list_head for iclog callbacks Christoph Hellwig
2019-05-20 13:12 ` Brian Foster
2019-05-20 13:19 ` Christoph Hellwig
2019-05-20 13:25 ` Brian Foster
2019-05-20 13:27 ` Bryan Gurney
2019-05-20 13:31 ` Christoph Hellwig
2019-05-17 7:31 ` [PATCH 12/20] xfs: remove a pointless comment duplicated above all xfs_item_ops instances Christoph Hellwig
2019-05-20 13:12 ` Brian Foster
2019-05-17 7:31 ` [PATCH 13/20] xfs: merge xfs_efd_init into xfs_trans_get_efd Christoph Hellwig
2019-05-17 8:16 ` Nikolay Borisov
2019-05-17 8:27 ` Christoph Hellwig
2019-05-17 18:26 ` Eric Sandeen
2019-05-20 6:03 ` Christoph Hellwig
2019-05-20 13:12 ` Brian Foster
2019-05-17 7:31 ` [PATCH 14/20] xfs: merge xfs_cud_init into xfs_trans_get_cud Christoph Hellwig
2019-05-20 13:13 ` Brian Foster
2019-05-17 7:31 ` [PATCH 15/20] xfs: merge xfs_rud_init into xfs_trans_get_rud Christoph Hellwig
2019-05-20 13:13 ` Brian Foster
2019-05-17 7:31 ` [PATCH 16/20] xfs: merge xfs_bud_init into xfs_trans_get_bud Christoph Hellwig
2019-05-20 13:13 ` Brian Foster
2019-05-17 7:31 ` [PATCH 17/20] xfs: merge xfs_trans_extfree.c into xfs_extfree_item.c Christoph Hellwig
2019-05-20 13:13 ` Brian Foster
2019-05-17 7:31 ` [PATCH 18/20] xfs: merge xfs_trans_refcount.c into xfs_refcount_item.c Christoph Hellwig
2019-05-20 13:14 ` Brian Foster
2019-05-17 7:31 ` [PATCH 19/20] xfs: merge xfs_trans_rmap.c into xfs_rmap_item.c Christoph Hellwig
2019-05-20 13:14 ` Brian Foster
2019-05-17 7:31 ` [PATCH 20/20] xfs: merge xfs_trans_bmap.c into xfs_bmap_item.c Christoph Hellwig
2019-05-20 13:14 ` Brian Foster
-- strict thread matches above, loose matches on Subject: below --
2019-06-13 18:02 misc log item related cleanups v2 Christoph Hellwig
2019-06-13 18:02 ` [PATCH 02/20] xfs: stop using XFS_LI_ABORTED as a parameter flag Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611084646.GA22981@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).