From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:57628 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406508AbfFLHp4 (ORCPT ); Wed, 12 Jun 2019 03:45:56 -0400 Date: Wed, 12 Jun 2019 09:45:27 +0200 From: Christoph Hellwig Subject: Re: alternative take on the same page merging leak fix Message-ID: <20190612074527.GA20491@lst.de> References: <20190611151007.13625-1-hch@lst.de> <20190612010922.GA17522@ming.t460p> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190612010922.GA17522@ming.t460p> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , David Gibson , "Darrick J. Wong" , linux-block@vger.kernel.org, linux-xfs@vger.kernel.org On Wed, Jun 12, 2019 at 09:09:23AM +0800, Ming Lei wrote: > We have to backport the fixes to -stable tree, and downstream need to > ship the fix too. > > The issue is quite serious because the leak is in IO path and the whole > system ram can be used up easily on some workloads. So I think the fix > should be for 5.2, however, regression risk might be increased by > pulling cleanup & re-factor in now. > > I really appreciate you may cook a fix-only patch for this issue. > Especially the change in add pc page code isn't necessary for fixing > the issue. Patches 3 and 4 have no dependencies on 1 and 2, and should have arguably been ordered first in the series.