From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] mkfs: remove useless log options in usage
Date: Wed, 12 Jun 2019 08:01:55 -0700 [thread overview]
Message-ID: <20190612150155.GA3773859@magnolia> (raw)
In-Reply-To: <1560330575-2209-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
On Wed, Jun 12, 2019 at 05:09:35PM +0800, Yang Xu wrote:
> Since commit 2cf637cf(mkfs: remove logarithm based CLI options),
> xfsprogs has discarded log options in node_options, remove it in usage.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> mkfs/xfs_mkfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index db3ad38e..91391b72 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -858,7 +858,7 @@ usage( void )
> (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
> sectsize=num\n\
> /* force overwrite */ [-f]\n\
> -/* inode size */ [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
> +/* inode size */ [-i perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
> projid32bit=0|1,sparse=0|1]\n\
> /* no discard */ [-K]\n\
> /* log subvol */ [-l agnum=n,internal,size=num,logdev=xxx,version=n\n\
> --
> 2.18.1
>
>
>
next prev parent reply other threads:[~2019-06-12 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 9:09 [PATCH] mkfs: remove useless log options in usage Yang Xu
2019-06-12 15:01 ` Darrick J. Wong [this message]
2019-06-26 1:42 ` Yang Xu
2019-06-26 2:56 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612150155.GA3773859@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xuyang2018.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox