From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 05/24] xfs: remove the l_iclog_size_log field from strut xlog
Date: Mon, 17 Jun 2019 16:08:35 -0700 [thread overview]
Message-ID: <20190617230835.GO3773859@magnolia> (raw)
In-Reply-To: <20190605191511.32695-6-hch@lst.de>
On Wed, Jun 05, 2019 at 09:14:52PM +0200, Christoph Hellwig wrote:
> This field is never used, so we can simply kill it.
s/strut xlog/struct xlog/ in the subject; will fix it in the series if I
end up pulling it in...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_log.c | 9 ---------
> fs/xfs/xfs_log_priv.h | 1 -
> 2 files changed, 10 deletions(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index a2048e46be4e..8033b64092bb 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1307,7 +1307,6 @@ xlog_get_iclog_buffer_size(
> struct xfs_mount *mp,
> struct xlog *log)
> {
> - int size;
> int xhdrs;
>
> if (mp->m_logbufs <= 0)
> @@ -1319,13 +1318,6 @@ xlog_get_iclog_buffer_size(
> * Buffer size passed in from mount system call.
> */
> if (mp->m_logbsize > 0) {
> - size = log->l_iclog_size = mp->m_logbsize;
> - log->l_iclog_size_log = 0;
> - while (size != 1) {
> - log->l_iclog_size_log++;
> - size >>= 1;
> - }
> -
> if (xfs_sb_version_haslogv2(&mp->m_sb)) {
> /* # headers = size / 32k
> * one header holds cycles from 32k of data
> @@ -1346,7 +1338,6 @@ xlog_get_iclog_buffer_size(
>
> /* All machines use 32kB buffers by default. */
> log->l_iclog_size = XLOG_BIG_RECORD_BSIZE;
> - log->l_iclog_size_log = XLOG_BIG_RECORD_BSHIFT;
>
> /* the default log size is 16k or 32k which is one header sector */
> log->l_iclog_hsize = BBSIZE;
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index b5f82cb36202..78a2abeba895 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -361,7 +361,6 @@ struct xlog {
> int l_iclog_heads; /* # of iclog header sectors */
> uint l_sectBBsize; /* sector size in BBs (2^n) */
> int l_iclog_size; /* size of log in bytes */
> - int l_iclog_size_log; /* log power size of log */
> int l_iclog_bufs; /* number of iclog buffers */
> xfs_daddr_t l_logBBstart; /* start block of log */
> int l_logsize; /* size of log in bytes */
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-06-17 23:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 19:14 use bios directly in the log code v4 Christoph Hellwig
2019-06-05 19:14 ` [PATCH 01/24] xfs: remove the no-op spinlock_destroy stub Christoph Hellwig
2019-06-05 19:14 ` [PATCH 02/24] xfs: remove the never used _XBF_COMPOUND flag Christoph Hellwig
2019-06-05 19:14 ` [PATCH 03/24] xfs: renumber XBF_WRITE_FAIL Christoph Hellwig
2019-06-05 19:14 ` [PATCH 04/24] xfs: make mem_to_page available outside of xfs_buf.c Christoph Hellwig
2019-06-05 19:14 ` [PATCH 05/24] xfs: remove the l_iclog_size_log field from strut xlog Christoph Hellwig
2019-06-05 21:17 ` Dave Chinner
2019-06-17 23:08 ` Darrick J. Wong [this message]
2019-06-05 19:14 ` [PATCH 06/24] xfs: cleanup xlog_get_iclog_buffer_size Christoph Hellwig
2019-06-05 21:21 ` Dave Chinner
2019-06-05 19:14 ` [PATCH 07/24] xfs: reformat xlog_get_lowest_lsn Christoph Hellwig
2019-06-05 19:14 ` [PATCH 08/24] xfs: remove XLOG_STATE_IOABORT Christoph Hellwig
2019-06-06 0:13 ` Dave Chinner
2019-06-05 19:14 ` [PATCH 09/24] xfs: don't use REQ_PREFLUSH for split log writes Christoph Hellwig
2019-06-05 19:14 ` [PATCH 10/24] xfs: factor out log buffer writing from xlog_sync Christoph Hellwig
2019-06-05 19:14 ` [PATCH 11/24] xfs: factor out splitting of an iclog " Christoph Hellwig
2019-06-05 19:14 ` [PATCH 12/24] xfs: factor out iclog size calculation " Christoph Hellwig
2019-06-05 19:15 ` [PATCH 13/24] xfs: update both stat counters together in xlog_sync Christoph Hellwig
2019-06-05 19:15 ` [PATCH 14/24] xfs: remove the syncing argument from xlog_verify_iclog Christoph Hellwig
2019-06-05 19:15 ` [PATCH 15/24] xfs: make use of the l_targ field in struct xlog Christoph Hellwig
2019-06-05 19:15 ` [PATCH 16/24] xfs: use bios directly to write log buffers Christoph Hellwig
2019-06-17 23:27 ` Darrick J. Wong
2019-06-18 5:58 ` Christoph Hellwig
2019-06-05 19:15 ` [PATCH 17/24] xfs: move the log ioend workqueue to struct xlog Christoph Hellwig
2019-06-05 19:15 ` [PATCH 18/24] xfs: return an offset instead of a pointer from xlog_align Christoph Hellwig
2019-06-05 19:15 ` [PATCH 19/24] xfs: use bios directly to read and write the log recovery buffers Christoph Hellwig
2019-07-08 7:37 ` Dave Chinner
2019-07-08 16:19 ` Darrick J. Wong
2019-07-08 16:24 ` Christoph Hellwig
2019-07-08 21:34 ` Christoph Hellwig
2019-07-08 22:15 ` Dave Chinner
2019-07-09 15:23 ` Christoph Hellwig
2019-07-09 15:44 ` Darrick J. Wong
2019-06-05 19:15 ` [PATCH 20/24] xfs: stop using bp naming for " Christoph Hellwig
2019-06-05 19:15 ` [PATCH 21/24] xfs: remove unused buffer cache APIs Christoph Hellwig
2019-06-05 19:15 ` [PATCH 22/24] xfs: properly type the b_log_item field in struct xfs_buf Christoph Hellwig
2019-06-05 19:15 ` [PATCH 23/24] xfs: remove the b_io_length " Christoph Hellwig
2019-06-05 19:15 ` [PATCH 24/24] xfs: add struct xfs_mount pointer to " Christoph Hellwig
2019-06-17 23:30 ` use bios directly in the log code v4 Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617230835.GO3773859@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox