From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH 1/4] xfs: separate inode geometry
Date: Tue, 18 Jun 2019 13:52:52 -0700 [thread overview]
Message-ID: <20190618205252.GR5387@magnolia> (raw)
In-Reply-To: <20190618181732.GA873@infradead.org>
On Tue, Jun 18, 2019 at 11:17:32AM -0700, Christoph Hellwig wrote:
> Sorry for spotting this so late, but this one is pretty bogus as-is.
>
> The geometry information is not an on-disk structure in any sense,
> and has absolutely no business in xfs_format.h.
Ok I'll move it.
--D
next prev parent reply other threads:[~2019-06-18 20:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 21:48 [PATCH v2 0/4] xfs: refactor inode geometry Darrick J. Wong
2019-06-04 21:48 ` [PATCH 1/4] xfs: separate " Darrick J. Wong
2019-06-18 18:17 ` Christoph Hellwig
2019-06-18 20:52 ` Darrick J. Wong [this message]
2019-06-04 21:49 ` [PATCH 2/4] xfs: refactor inode geometry setup routines Darrick J. Wong
2019-06-04 22:04 ` Dave Chinner
2019-06-04 21:49 ` [PATCH 3/4] xfs: fix inode_cluster_size rounding mayhem Darrick J. Wong
2019-06-04 22:05 ` Dave Chinner
2019-06-05 0:24 ` Darrick J. Wong
2019-06-04 21:49 ` [PATCH 4/4] xfs: finish converting to inodes_per_cluster Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618205252.GR5387@magnolia \
--to=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox