From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH] xfs: move xfs_ino_geometry to xfs_mount.h
Date: Tue, 18 Jun 2019 18:07:04 -0700 [thread overview]
Message-ID: <20190619010704.GA5402@magnolia> (raw)
In-Reply-To: <20190619004041.GA26375@dread.disaster.area>
On Wed, Jun 19, 2019 at 10:40:41AM +1000, Dave Chinner wrote:
> On Tue, Jun 18, 2019 at 01:59:36PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > The inode geometry structure isn't related to ondisk format; it's
> > support for the mount structure. Move it to xfs_mount.h.
>
> That means we have to duplicate it in userspace - xfs_mount.h is not
> shared. I'd suggest that libxfs/xfs_shared.h would be a better place
> for it.
Well that will make the patch wayyy bigger since now every file has to
include xfs_shared.h (right now 26 of them do not)...
--D
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2019-06-19 1:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 20:59 [PATCH] xfs: move xfs_ino_geometry to xfs_mount.h Darrick J. Wong
2019-06-19 0:40 ` Dave Chinner
2019-06-19 1:07 ` Darrick J. Wong [this message]
2019-06-19 1:13 ` [PATCH v2] xfs: move xfs_ino_geometry to xfs_shared.h Darrick J. Wong
2019-06-20 21:31 ` Dave Chinner
2019-06-25 14:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619010704.GA5402@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).