From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:57814 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726251AbfFSWvo (ORCPT ); Wed, 19 Jun 2019 18:51:44 -0400 Date: Wed, 19 Jun 2019 15:51:36 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 14/20] xfs: move the log ioend workqueue to struct xlog Message-ID: <20190619225136.GU5387@magnolia> References: <20190603172945.13819-1-hch@lst.de> <20190603172945.13819-15-hch@lst.de> <20190619121908.GA11894@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190619121908.GA11894@lst.de> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org On Wed, Jun 19, 2019 at 02:19:08PM +0200, Christoph Hellwig wrote: > The build/test bot found an issue with this one leading to crashes > at unmount, and I think this incremental patch should fix it: I have't see any crashes at unmount; would you mind sharing the report? --D > diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c > index 66b87cce69b9..c66757251809 100644 > --- a/fs/xfs/xfs_log.c > +++ b/fs/xfs/xfs_log.c > @@ -1954,7 +1954,6 @@ xlog_dealloc_log( > int i; > > xlog_cil_destroy(log); > - destroy_workqueue(log->l_ioend_workqueue); > > /* > * Cycle all the iclogbuf locks to make sure all log IO completion > @@ -1976,6 +1975,7 @@ xlog_dealloc_log( > } > > log->l_mp->m_log = NULL; > + destroy_workqueue(log->l_ioend_workqueue); > kmem_free(log); > } /* xlog_dealloc_log */ >