Re: [PATCH] xfs: move xfs_ino_geometry to xfs_mount.h

Darrick J. Wong
2019-06-19T01:07:35Z

On Wed, Jun 19, 2019 at 10:40:41AM +1000, Dave Chinner wrote:
> On Tue, Jun 18, 2019 at 01:59:36PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > The inode geometry structure isn't related to ondisk format; it's
> > support for the mount structure. Move it to xfs_mount.h.
>
> That means we have to duplicate it in userspace - xfs_mount.h is not
> shared. I'd suggest that libxfs/xfs_shared.h would be a better place
> for it.

Well that will make the patch wayyy bigger since now every file has to
include xfs_shared.h (right now 26 of them do not)...

--D

> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com