Re: [PATCH v2] xfs: move xfs_ino_geometry to xfs_shared.h

Dave Chinner
2019-06-20T21:32:07Z

On Tue, Jun 18, 2019 at 06:13:09PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The inode geometry structure isn't related to ondisk format; it's
> support for the mount structure. Move it to xfs_shared.h.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> v2: move it to xfs_shared.h, which now every file has to include
> ---
> fs/xfs/libxfs/xfs_dir2.c | 1 +
> fs/xfs/libxfs/xfs_dir2_block.c | 1 +
> fs/xfs/libxfs/xfs_dir2_data.c | 1 +
> fs/xfs/libxfs/xfs_dir2_leaf.c | 1 +
> fs/xfs/libxfs/xfs_dir2_node.c | 1 +
> fs/xfs/libxfs/xfs_dir2_sf.c | 1 +
> fs/xfs/libxfs/xfs_format.h | 41 ---------------------------------------
> fs/xfs/libxfs/xfs_iext_tree.c | 1 +
> fs/xfs/libxfs/xfs_inode_fork.c | 1 +
> fs/xfs/libxfs/xfs_shared.h | 42 ++++++++++++++++++++++++++++++++++++++++
> fs/xfs/xfs_acl.c | 1 +
> fs/xfs/xfs_attr_list.c | 1 +
> fs/xfs/xfs_buf.c | 1 +
> fs/xfs/xfs_buf_item.c | 1 +
> fs/xfs/xfs_dir2_readdir.c | 1 +
> fs/xfs/xfs_discard.c | 1 +
> fs/xfs/xfs_dquot_item.c | 1 +
> fs/xfs/xfs_error.c | 1 +
> fs/xfs/xfs_export.c | 1 +
> fs/xfs/xfs_filestream.c | 1 +
> fs/xfs/xfs_icache.c | 1 +
> fs/xfs/xfs_inode_item.c | 1 +
> fs/xfs/xfs_ioctl32.c | 1 +
> fs/xfs/xfs_message.c | 1 +
> fs/xfs/xfs_pnfs.c | 1 +
> fs/xfs/xfs_qm_bhv.c | 1 +
> fs/xfs/xfs_quotaops.c | 1 +
> fs/xfs/xfs_trans_ail.c | 1 +
> fs/xfs/xfs_xattr.c | 1 +
> 29 files changed, 69 insertions(+), 41 deletions(-)

Bigger patch, but I think it's the right way to do this.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com