From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_repair: don't search for libxfs.h in system headers
Date: Fri, 21 Jun 2019 09:06:10 -0700 [thread overview]
Message-ID: <20190621160610.GY5387@magnolia> (raw)
In-Reply-To: <b1265852-70ea-5402-191d-b3843996fc89@redhat.com>
On Fri, Jun 21, 2019 at 10:28:03AM -0500, Eric Sandeen wrote:
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> And now for something completely different: a noncontroversial,
> trivially reviewable #include change!
>
> (right?)
>
> diff --git a/repair/rmap.c b/repair/rmap.c
> index 47828a06..019df71c 100644
> --- a/repair/rmap.c
> +++ b/repair/rmap.c
> @@ -3,7 +3,7 @@
> * Copyright (C) 2016 Oracle. All Rights Reserved.
> * Author: Darrick J. Wong <darrick.wong@oracle.com>
> */
> -#include <libxfs.h>
> +#include "libxfs.h"
> #include "btree.h"
> #include "err_protos.h"
> #include "libxlog.h"
> diff --git a/repair/slab.c b/repair/slab.c
> index ba5c2327..d5947a5a 100644
> --- a/repair/slab.c
> +++ b/repair/slab.c
> @@ -3,7 +3,7 @@
> * Copyright (C) 2016 Oracle. All Rights Reserved.
> * Author: Darrick J. Wong <darrick.wong@oracle.com>
> */
> -#include <libxfs.h>
> +#include "libxfs.h"
> #include "slab.h"
>
> #undef SLAB_DEBUG
>
next prev parent reply other threads:[~2019-06-21 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 15:28 [PATCH] xfs_repair: don't search for libxfs.h in system headers Eric Sandeen
2019-06-21 16:06 ` Darrick J. Wong [this message]
2019-06-25 10:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621160610.GY5387@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).