linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xfs_repair: don't search for libxfs.h in system headers
@ 2019-06-21 15:28 Eric Sandeen
  2019-06-21 16:06 ` Darrick J. Wong
  2019-06-25 10:49 ` Christoph Hellwig
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2019-06-21 15:28 UTC (permalink / raw)
  To: linux-xfs

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

And now for something completely different: a noncontroversial,
trivially reviewable #include change!

(right?)

diff --git a/repair/rmap.c b/repair/rmap.c
index 47828a06..019df71c 100644
--- a/repair/rmap.c
+++ b/repair/rmap.c
@@ -3,7 +3,7 @@
  * Copyright (C) 2016 Oracle.  All Rights Reserved.
  * Author: Darrick J. Wong <darrick.wong@oracle.com>
  */
-#include <libxfs.h>
+#include "libxfs.h"
 #include "btree.h"
 #include "err_protos.h"
 #include "libxlog.h"
diff --git a/repair/slab.c b/repair/slab.c
index ba5c2327..d5947a5a 100644
--- a/repair/slab.c
+++ b/repair/slab.c
@@ -3,7 +3,7 @@
  * Copyright (C) 2016 Oracle.  All Rights Reserved.
  * Author: Darrick J. Wong <darrick.wong@oracle.com>
  */
-#include <libxfs.h>
+#include "libxfs.h"
 #include "slab.h"
 
 #undef SLAB_DEBUG

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs_repair: don't search for libxfs.h in system headers
  2019-06-21 15:28 [PATCH] xfs_repair: don't search for libxfs.h in system headers Eric Sandeen
@ 2019-06-21 16:06 ` Darrick J. Wong
  2019-06-25 10:49 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2019-06-21 16:06 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: linux-xfs

On Fri, Jun 21, 2019 at 10:28:03AM -0500, Eric Sandeen wrote:
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
> And now for something completely different: a noncontroversial,
> trivially reviewable #include change!
> 
> (right?)
> 
> diff --git a/repair/rmap.c b/repair/rmap.c
> index 47828a06..019df71c 100644
> --- a/repair/rmap.c
> +++ b/repair/rmap.c
> @@ -3,7 +3,7 @@
>   * Copyright (C) 2016 Oracle.  All Rights Reserved.
>   * Author: Darrick J. Wong <darrick.wong@oracle.com>
>   */
> -#include <libxfs.h>
> +#include "libxfs.h"
>  #include "btree.h"
>  #include "err_protos.h"
>  #include "libxlog.h"
> diff --git a/repair/slab.c b/repair/slab.c
> index ba5c2327..d5947a5a 100644
> --- a/repair/slab.c
> +++ b/repair/slab.c
> @@ -3,7 +3,7 @@
>   * Copyright (C) 2016 Oracle.  All Rights Reserved.
>   * Author: Darrick J. Wong <darrick.wong@oracle.com>
>   */
> -#include <libxfs.h>
> +#include "libxfs.h"
>  #include "slab.h"
>  
>  #undef SLAB_DEBUG
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs_repair: don't search for libxfs.h in system headers
  2019-06-21 15:28 [PATCH] xfs_repair: don't search for libxfs.h in system headers Eric Sandeen
  2019-06-21 16:06 ` Darrick J. Wong
@ 2019-06-25 10:49 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2019-06-25 10:49 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: linux-xfs

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-25 10:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-21 15:28 [PATCH] xfs_repair: don't search for libxfs.h in system headers Eric Sandeen
2019-06-21 16:06 ` Darrick J. Wong
2019-06-25 10:49 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).