From: Christoph Hellwig <hch@lst.de>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Christoph Hellwig <hch@lst.de>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] shared/011: run on all file system that support cgroup writeback
Date: Tue, 25 Jun 2019 11:59:17 +0200 [thread overview]
Message-ID: <20190625095917.GB1462@lst.de> (raw)
In-Reply-To: <20190624150839.GB6350@mit.edu>
On Mon, Jun 24, 2019 at 11:08:39AM -0400, Theodore Ts'o wrote:
> Per my comments in another e-mail thread, given how many of the
> primary file systems support cgroup-aware writeback, maybe we should
> just remove the _supported_fs line and move this test to generic?
>
> Whether we like it or not, there are more and more userspace tools
> which assume that cgroup-aware writeback is a thing.
>
> Alternatively, maybe we should have some standardized way so the
> kernel can signal whether or not a particular mounted file system
> supports cgroup-aware writeback?
I'm fine with moving the patch to generic as said. I'm fine saying
we assume cgroup wb support for block device based file systems,
xfs was the only major one missing, and the support is pretty trivial
as well.
prev parent reply other threads:[~2019-06-25 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 13:44 [PATCH] shared/011: run on all file system that support cgroup writeback Christoph Hellwig
2019-06-24 15:08 ` Theodore Ts'o
2019-06-24 15:19 ` Darrick J. Wong
2019-06-26 3:17 ` Eryu Guan
2019-06-25 9:59 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625095917.GB1462@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).