From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:35902 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730505AbfFYOr1 (ORCPT ); Tue, 25 Jun 2019 10:47:27 -0400 Date: Tue, 25 Jun 2019 07:47:07 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 12/12] iomap: add tracing for the address space operations Message-ID: <20190625144707.GC5379@magnolia> References: <20190624055253.31183-1-hch@lst.de> <20190624055253.31183-13-hch@lst.de> <20190624234921.GE7777@dread.disaster.area> <20190625101515.GL1462@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190625101515.GL1462@lst.de> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: Dave Chinner , Damien Le Moal , Andreas Gruenbacher , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Jun 25, 2019 at 12:15:15PM +0200, Christoph Hellwig wrote: > On Tue, Jun 25, 2019 at 09:49:21AM +1000, Dave Chinner wrote: > > > +#undef TRACE_SYSTEM > > > +#define TRACE_SYSTEM iomap > > > > Can you add a comment somewhere here that says these tracepoints are > > volatile and we reserve the right to change them at any time so they > > don't form any sort of persistent UAPI that we have to maintain? > > Sure. Note that we don't have any such comment in xfs either.. I think we ought to add a comment to both of the tracepoint header files in xfs then... --D