From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:58130 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726489AbfF0AWs (ORCPT ); Wed, 26 Jun 2019 20:22:48 -0400 Date: Wed, 26 Jun 2019 17:19:26 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 2/5] vfs: create a generic checking function for FS_IOC_FSSETXATTR Message-ID: <20190627001926.GL5171@magnolia> References: <156151632209.2283456.3592379873620132456.stgit@magnolia> <156151633829.2283456.834142172527987802.stgit@magnolia> <20190626041133.GB32272@ZenIV.linux.org.uk> <20190626153542.GE5171@magnolia> <20190626154302.GA31445@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190626154302.GA31445@infradead.org> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: Al Viro , matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu, shaggy@kernel.org, ard.biesheuvel@linaro.org, josef@toxicpanda.com, clm@fb.com, adilger.kernel@dilger.ca, jk@ozlabs.org, jack@suse.com, dsterba@suse.com, jaegeuk@kernel.org, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-efi@vger.kernel.org, Jan Kara , reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org On Wed, Jun 26, 2019 at 08:43:02AM -0700, Christoph Hellwig wrote: > On Wed, Jun 26, 2019 at 08:35:42AM -0700, Darrick J. Wong wrote: > > > static inline void simple_fill_fsxattr(struct fsxattr *fa, unsigned xflags) > > > { > > > memset(fa, 0, sizeof(*fa)); > > > fa->fsx_xflags = xflags; > > > } > > > > > > and let the compiler optimize the crap out? > > > > The v2 series used to do that, but Christoph complained that having a > > helper for a two-line memset and initialization was silly[1] so now we > > have this version. > > > > I don't mind reinstating it as a static inline helper, but I'd like some > > input from any of the btrfs developers (or you, Al) about which form is > > preferred. > > I complained having that helper in btrfs. I think Al wants a generic > one, which at least makes a little more sense. Ok. > That being said I wonder if we should lift these attr ioctls to > file op methods and deal with all that crap in VFS code instead of > having all those duplicated ioctl parsers. That sounds like an excellent next patchset. :) --D