Linux XFS filesystem development
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: "Holger Hoffstätte" <holger@applied-asynchrony.com>,
	linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: Include 'xfs: speed up large directory modifications' in 5.3?
Date: Sun, 30 Jun 2019 16:11:30 -0700	[thread overview]
Message-ID: <20190630231130.GA1654093@magnolia> (raw)
In-Reply-To: <20190630223605.GK7777@dread.disaster.area>

On Mon, Jul 01, 2019 at 08:36:05AM +1000, Dave Chinner wrote:
> On Sun, Jun 30, 2019 at 08:39:55AM -0700, Darrick J. Wong wrote:
> > On Sun, Jun 30, 2019 at 01:28:09PM +0200, Holger Hoffstätte wrote:
> > > Hi,
> > > 
> > > I have been running with Dave's series for faster directory inserts since
> > > forever without any issues, and the last revision [1] still applies cleanly
> > > to current5.2-rc (not sure about xfs-next though).
> > > Any chance this can be included in 5.3? IMHO it would be a shame if this
> > > fell through the cracks again.
> > > 
> > > Thanks,
> > > Holger
> > > 
> > > [1] https://patchwork.kernel.org/project/xfs/list/?series=34713
> > 
> > Christoph reviewed most of the series, but it looked like he and Dave
> > went back and forth a bit on the second to last patch and Dave never
> > sent a v2 series or a request to just merge it as is, so I didn't take
> > any action.  Hey Dave, are you still working on a resubmission for this
> > series?
> 
> It's in my stack somewhere. Not for this cycle. Can't even remember
> what was the issue with it.  I'm pretty sure that was about when the
> whole copy file range debacle exploded in our faces, which was why
> there was no followup back then...

I vague recollection is that I looked at it and remember thinking it was
fine except maybe for the tweaks hch suggested, and then copyfilerange
blew up and that was it, everything got derailed. :(

/me shakes fist at crAPIs....

--D

> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com

      reply	other threads:[~2019-06-30 23:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-30 11:28 Include 'xfs: speed up large directory modifications' in 5.3? Holger Hoffstätte
2019-06-30 15:39 ` Darrick J. Wong
2019-06-30 22:36   ` Dave Chinner
2019-06-30 23:11     ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190630231130.GA1654093@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=holger@applied-asynchrony.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox