* [PATCH] xfs: don't update lastino for FSBULKSTAT_SINGLE
@ 2019-07-06 21:25 Darrick J. Wong
2019-07-07 0:19 ` Allison Collins
2019-07-08 12:28 ` Brian Foster
0 siblings, 2 replies; 3+ messages in thread
From: Darrick J. Wong @ 2019-07-06 21:25 UTC (permalink / raw)
To: xfs, kernel test robot; +Cc: Brian Foster, lkp
From: Darrick J. Wong <darrick.wong@oracle.com>
The kernel test robot found a regression of xfs/054 in the conversion of
bulkstat to use the new iwalk infrastructure -- if a caller set *lastip
= 128 and invoked FSBULKSTAT_SINGLE, the bstat info would be for inode
128, but *lastip would be increased by the kernel to 129.
FSBULKSTAT_SINGLE never incremented lastip before, so it's incorrect to
make such an update to the internal lastino value now.
Fixes: 2810bd6840e463 ("xfs: convert bulkstat to new iwalk infrastructure")
Reported-by: kernel test robot <rong.a.chen@intel.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_ioctl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 6bf04e71325b..1876461e5104 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -797,7 +797,6 @@ xfs_ioc_fsbulkstat(
breq.startino = lastino;
breq.icount = 1;
error = xfs_bulkstat_one(&breq, xfs_fsbulkstat_one_fmt);
- lastino = breq.startino;
} else { /* XFS_IOC_FSBULKSTAT */
breq.startino = lastino ? lastino + 1 : 0;
error = xfs_bulkstat(&breq, xfs_fsbulkstat_one_fmt);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: don't update lastino for FSBULKSTAT_SINGLE
2019-07-06 21:25 [PATCH] xfs: don't update lastino for FSBULKSTAT_SINGLE Darrick J. Wong
@ 2019-07-07 0:19 ` Allison Collins
2019-07-08 12:28 ` Brian Foster
1 sibling, 0 replies; 3+ messages in thread
From: Allison Collins @ 2019-07-07 0:19 UTC (permalink / raw)
To: Darrick J. Wong, xfs, kernel test robot; +Cc: Brian Foster, lkp
On 7/6/19 2:25 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The kernel test robot found a regression of xfs/054 in the conversion of
> bulkstat to use the new iwalk infrastructure -- if a caller set *lastip
> = 128 and invoked FSBULKSTAT_SINGLE, the bstat info would be for inode
> 128, but *lastip would be increased by the kernel to 129.
>
> FSBULKSTAT_SINGLE never incremented lastip before, so it's incorrect to
> make such an update to the internal lastino value now.
>
Looks ok to me. Thanks!
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
> Fixes: 2810bd6840e463 ("xfs: convert bulkstat to new iwalk infrastructure")
> Reported-by: kernel test robot <rong.a.chen@intel.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_ioctl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index 6bf04e71325b..1876461e5104 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -797,7 +797,6 @@ xfs_ioc_fsbulkstat(
> breq.startino = lastino;
> breq.icount = 1;
> error = xfs_bulkstat_one(&breq, xfs_fsbulkstat_one_fmt);
> - lastino = breq.startino;
> } else { /* XFS_IOC_FSBULKSTAT */
> breq.startino = lastino ? lastino + 1 : 0;
> error = xfs_bulkstat(&breq, xfs_fsbulkstat_one_fmt);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: don't update lastino for FSBULKSTAT_SINGLE
2019-07-06 21:25 [PATCH] xfs: don't update lastino for FSBULKSTAT_SINGLE Darrick J. Wong
2019-07-07 0:19 ` Allison Collins
@ 2019-07-08 12:28 ` Brian Foster
1 sibling, 0 replies; 3+ messages in thread
From: Brian Foster @ 2019-07-08 12:28 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs, kernel test robot, lkp
On Sat, Jul 06, 2019 at 02:25:17PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The kernel test robot found a regression of xfs/054 in the conversion of
> bulkstat to use the new iwalk infrastructure -- if a caller set *lastip
> = 128 and invoked FSBULKSTAT_SINGLE, the bstat info would be for inode
> 128, but *lastip would be increased by the kernel to 129.
>
> FSBULKSTAT_SINGLE never incremented lastip before, so it's incorrect to
> make such an update to the internal lastino value now.
>
> Fixes: 2810bd6840e463 ("xfs: convert bulkstat to new iwalk infrastructure")
> Reported-by: kernel test robot <rong.a.chen@intel.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_ioctl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index 6bf04e71325b..1876461e5104 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -797,7 +797,6 @@ xfs_ioc_fsbulkstat(
> breq.startino = lastino;
> breq.icount = 1;
> error = xfs_bulkstat_one(&breq, xfs_fsbulkstat_one_fmt);
> - lastino = breq.startino;
> } else { /* XFS_IOC_FSBULKSTAT */
> breq.startino = lastino ? lastino + 1 : 0;
> error = xfs_bulkstat(&breq, xfs_fsbulkstat_one_fmt);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-08 12:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-06 21:25 [PATCH] xfs: don't update lastino for FSBULKSTAT_SINGLE Darrick J. Wong
2019-07-07 0:19 ` Allison Collins
2019-07-08 12:28 ` Brian Foster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).