From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:33772 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725787AbfGOG5r (ORCPT ); Mon, 15 Jul 2019 02:57:47 -0400 Date: Mon, 15 Jul 2019 08:57:45 +0200 From: Johannes Thumshirn Subject: Re: [PATCH RFC] fs: New zonefs file system Message-ID: <20190715065745.GA4495@x250> References: <20190712030017.14321-1-damien.lemoal@wdc.com> <20190715011935.GM7689@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190715011935.GM7689@dread.disaster.area> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Chinner Cc: Damien Le Moal , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, Christoph Hellwig , Hannes Reinecke On Mon, Jul 15, 2019 at 11:19:35AM +1000, Dave Chinner wrote: [...] > > +/* > > + * Open a file. > > + */ > > +static int zonefs_file_open(struct inode *inode, struct file *file) > > +{ > > + /* > > + * Note: here we can do an explicit open of the file zone, > > + * on the first open of the inode. The explicit close can be > > + * done on the last release (close) call for the inode. > > + */ > > + > > + return generic_file_open(inode, file); > > +} > > Why is a wrapper needed for this? AFAIR this is a left over from an older patch of me where an open of a sequential only zone automagically appended O_APPEND, but this broke all kinds of assumptions user-space did so Damien ripped it out again. So yes the wrapper can go as well. Byte, Johannes -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850