From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] xfs: sync up xfs_trans_inode with userspace
Date: Mon, 15 Jul 2019 07:30:08 -0400 [thread overview]
Message-ID: <20190715113007.GB23406@bfoster> (raw)
In-Reply-To: <112d2e52-c96c-af83-7e53-5fca12448c76@redhat.com>
On Fri, Jul 12, 2019 at 12:46:17PM -0500, Eric Sandeen wrote:
> Add an XFS_ICHGTIME_CREATE case to xfs_trans_ichgtime() to keep in
> sync with userspace. (Currently no kernel caller sends this flag.)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c
> index 93d14e47269d..a9ad90926b87 100644
> --- a/fs/xfs/libxfs/xfs_trans_inode.c
> +++ b/fs/xfs/libxfs/xfs_trans_inode.c
> @@ -66,6 +66,10 @@ xfs_trans_ichgtime(
> inode->i_mtime = tv;
> if (flags & XFS_ICHGTIME_CHG)
> inode->i_ctime = tv;
> + if (flags & XFS_ICHGTIME_CREATE) {
> + ip->i_d.di_crtime.t_sec = (int32_t)tv.tv_sec;
> + ip->i_d.di_crtime.t_nsec = (int32_t)tv.tv_nsec;
> + }
Could we add a "for libxfs" or some such one liner comment to this so
long as this is unused in the kernel? With that:
Reviewed-by: Brian Foster <bfoster@redhat.com>
> }
>
> /*
>
>
next prev parent reply other threads:[~2019-07-15 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 17:43 [PATCH 0/2] xfs: move & sync up xfs_trans_inode with userspace Eric Sandeen
2019-07-12 17:44 ` [PATCH 1/2] xfs: move xfs_trans_inode.c to libxfs/ Eric Sandeen
2019-07-15 11:29 ` Brian Foster
2019-07-12 17:46 ` [PATCH 2/2] xfs: sync up xfs_trans_inode with userspace Eric Sandeen
2019-07-15 11:30 ` Brian Foster [this message]
2019-07-15 15:09 ` Darrick J. Wong
2019-07-15 22:22 ` Dave Chinner
2019-07-16 0:03 ` Darrick J. Wong
2019-07-16 0:06 ` Eric Sandeen
2019-07-16 0:05 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715113007.GB23406@bfoster \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).