From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] xfs: sync up xfs_trans_inode with userspace
Date: Mon, 15 Jul 2019 17:03:03 -0700 [thread overview]
Message-ID: <20190716000303.GD6147@magnolia> (raw)
In-Reply-To: <20190715222209.GN7689@dread.disaster.area>
On Tue, Jul 16, 2019 at 08:22:09AM +1000, Dave Chinner wrote:
> On Fri, Jul 12, 2019 at 12:46:17PM -0500, Eric Sandeen wrote:
> > Add an XFS_ICHGTIME_CREATE case to xfs_trans_ichgtime() to keep in
> > sync with userspace. (Currently no kernel caller sends this flag.)
> >
> > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> > ---
> >
> > diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c
> > index 93d14e47269d..a9ad90926b87 100644
> > --- a/fs/xfs/libxfs/xfs_trans_inode.c
> > +++ b/fs/xfs/libxfs/xfs_trans_inode.c
> > @@ -66,6 +66,10 @@ xfs_trans_ichgtime(
> > inode->i_mtime = tv;
> > if (flags & XFS_ICHGTIME_CHG)
> > inode->i_ctime = tv;
> > + if (flags & XFS_ICHGTIME_CREATE) {
> > + ip->i_d.di_crtime.t_sec = (int32_t)tv.tv_sec;
> > + ip->i_d.di_crtime.t_nsec = (int32_t)tv.tv_nsec;
> > + }
>
> Please use the same format as the rest of the function. i.e.
>
> if (flags & XFS_ICHGTIME_CREATE)
> ip->i_d.di_crtime = tv;
>
> And convert userspace over to the same :P
How about promoting crtime to struct inode while we're at it?
(That said I think Eric was going for the quick resync now to keep
kernel libxfs in sync with xfsprogs libxfs...)
--D
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2019-07-16 0:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 17:43 [PATCH 0/2] xfs: move & sync up xfs_trans_inode with userspace Eric Sandeen
2019-07-12 17:44 ` [PATCH 1/2] xfs: move xfs_trans_inode.c to libxfs/ Eric Sandeen
2019-07-15 11:29 ` Brian Foster
2019-07-12 17:46 ` [PATCH 2/2] xfs: sync up xfs_trans_inode with userspace Eric Sandeen
2019-07-15 11:30 ` Brian Foster
2019-07-15 15:09 ` Darrick J. Wong
2019-07-15 22:22 ` Dave Chinner
2019-07-16 0:03 ` Darrick J. Wong [this message]
2019-07-16 0:06 ` Eric Sandeen
2019-07-16 0:05 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716000303.GD6147@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).