Re: [PATCH 4/9] iomap: move the SEEK_HOLE code into a separate file

Christoph Hellwig
2019-07-17T05:01:18Z

> diff --git a/fs/iomap/seek.c b/fs/iomap/seek.c
> new file mode 100644
> index 000000000000..0c36bef46522
> --- /dev/null
> +++ b/fs/iomap/seek.c
> @@ -0,0 +1,214 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2010 Red Hat, Inc.
> + * Copyright (c) 2016-2018 Christoph Hellwig.
> + */

This looks a little odd. There is nothing in here from Daves original
iomap prototype. It did start out with code from Andreas though which
might or might not be RH copyright. So we'll need Andreas and/or RH
legal to chime in.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>