Re: [PATCH 4/9] iomap: move the SEEK_HOLE code into a separate file

Darrick J. Wong
2019-07-17T14:53:47Z

On Wed, Jul 17, 2019 at 02:44:20PM +0200, Andreas Gruenbacher wrote:
> On Wed, 17 Jul 2019 at 07:01, Christoph Hellwig <hch@infradead.org> wrote:
> > > diff --git a/fs/iomap/seek.c b/fs/iomap/seek.c
> > > new file mode 100644
> > > index 000000000000..0c36bef46522
> > > --- /dev/null
> > > +++ b/fs/iomap/seek.c
> > > @@ -0,0 +1,214 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright (C) 2010 Red Hat, Inc.
> > > + * Copyright (c) 2016-2018 Christoph Hellwig.
> > > + */
> >
> > This looks a little odd. There is nothing in here from Daves original
> > iomap prototype. It did start out with code from Andreas though which
> > might or might not be RH copyright. So we'll need Andreas and/or RH
> > legal to chime in.
>
> That code should be Copyright (C) 2017 Red Hat, Inc.

Ok, fixed.

--D

> > Otherwise looks good:
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Thanks,
> Andreas