From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:59504 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726665AbfGRNIj (ORCPT ); Thu, 18 Jul 2019 09:08:39 -0400 Date: Thu, 18 Jul 2019 15:08:35 +0200 From: Christoph Hellwig Subject: Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n Message-ID: <20190718130835.GA28520@lst.de> References: <20190718125509.775525-1-arnd@arndb.de> <20190718125703.GA28332@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Arnd Bergmann Cc: Christoph Hellwig , Christoph Hellwig , "Darrick J. Wong" , linux-xfs , Linux FS-devel Mailing List , Andreas Gruenbacher , Hannes Reinecke , Souptick Joarder , Linux Kernel Mailing List , Masahiro Yamada , Jani Nikula On Thu, Jul 18, 2019 at 03:03:15PM +0200, Arnd Bergmann wrote: > The inclusion comes from the recently added header check in commit > c93a0368aaa2 ("kbuild: do not create wrappers for header-test-y"). > > This just tries to include every header by itself to see if there are build > failures from missing indirect includes. We probably don't want to > add an exception for iomap.h there. I very much disagree with that check. We don't need to make every header compilable with a setup where it should not be included. That being said if you feel this is worth fixing I'd rather define SECTOR_SIZE/SECTOR_SHIFT unconditionally.