From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2120.oracle.com ([156.151.31.85]:47056 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbfGRO2I (ORCPT ); Thu, 18 Jul 2019 10:28:08 -0400 Date: Thu, 18 Jul 2019 07:25:25 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n Message-ID: <20190718142525.GE7116@magnolia> References: <20190718125509.775525-1-arnd@arndb.de> <20190718125703.GA28332@lst.de> <20190718130835.GA28520@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718130835.GA28520@lst.de> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: Arnd Bergmann , Christoph Hellwig , linux-xfs , Linux FS-devel Mailing List , Andreas Gruenbacher , Hannes Reinecke , Souptick Joarder , Linux Kernel Mailing List , Masahiro Yamada , Jani Nikula On Thu, Jul 18, 2019 at 03:08:35PM +0200, Christoph Hellwig wrote: > On Thu, Jul 18, 2019 at 03:03:15PM +0200, Arnd Bergmann wrote: > > The inclusion comes from the recently added header check in commit > > c93a0368aaa2 ("kbuild: do not create wrappers for header-test-y"). > > > > This just tries to include every header by itself to see if there are build > > failures from missing indirect includes. We probably don't want to > > add an exception for iomap.h there. > > I very much disagree with that check. We don't need to make every > header compilable with a setup where it should not be included. Seconded, unless there's some scenario where someone needs iomap when CONFIG_BLOCK=n (???) --D > That being said if you feel this is worth fixing I'd rather define > SECTOR_SIZE/SECTOR_SHIFT unconditionally.