From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 5/3] various: disable quotas before running test
Date: Wed, 24 Jul 2019 08:56:10 -0700 [thread overview]
Message-ID: <20190724155610.GF7084@magnolia> (raw)
In-Reply-To: <156394156831.1850719.2997473679130010771.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
For all the tests which require that quotas be disabled, remove the
quota mount options before mounting the scratch filesystem.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/generic/384 | 4 ++--
tests/xfs/030 | 2 ++
tests/xfs/033 | 2 ++
tests/xfs/065 | 2 ++
4 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/generic/384 b/tests/generic/384
index b7c940d7..33098a38 100755
--- a/tests/generic/384
+++ b/tests/generic/384
@@ -37,8 +37,8 @@ _require_quota
_require_xfs_quota_foreign
_require_xfs_io_command "chproj"
-# we can't run with group quotas
-_exclude_scratch_mount_option "gquota" "grpquota"
+# we can't run with group quotas (on v4 xfs); the mount options for group
+# quotas will be filtered out by _qmount_option below.
dir=$SCRATCH_MNT/project
diff --git a/tests/xfs/030 b/tests/xfs/030
index 5ed99628..10854c8a 100755
--- a/tests/xfs/030
+++ b/tests/xfs/030
@@ -28,6 +28,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
. ./common/rc
. ./common/filter
. ./common/repair
+. ./common/quota
# nuke the superblock, AGI, AGF, AGFL; then try repair the damage
#
@@ -65,6 +66,7 @@ if [ $? -ne 0 ] # probably don't have a big enough scratch
then
_notrun "SCRATCH_DEV too small, results would be non-deterministic"
else
+ _qmount_option noquota
_scratch_mount
src/feature -U $SCRATCH_DEV && \
_notrun "UQuota are enabled, test needs controlled sb recovery"
diff --git a/tests/xfs/033 b/tests/xfs/033
index 5af0aefc..75b44f38 100755
--- a/tests/xfs/033
+++ b/tests/xfs/033
@@ -28,6 +28,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
. ./common/rc
. ./common/filter
. ./common/repair
+. ./common/quota
# nuke the root, rt bitmap, and rt summary inodes
#
@@ -80,6 +81,7 @@ _link_out_file_named $seqfull.out "$FEATURES"
sed -e 's/ //g' -e 's/^/export /'`
# check we won't get any quota inodes setup on mount
+_qmount_option noquota
_scratch_mount
src/feature -U $SCRATCH_DEV && \
_notrun "UQuota are enabled, test needs controlled sb recovery"
diff --git a/tests/xfs/065 b/tests/xfs/065
index f09bd947..b1533666 100755
--- a/tests/xfs/065
+++ b/tests/xfs/065
@@ -29,6 +29,7 @@ _cleanup()
. ./common/rc
. ./common/filter
. ./common/dump
+. ./common/quota
#
# list recursively the directory
@@ -57,6 +58,7 @@ _require_scratch
# so don't run it
#
_scratch_mkfs_xfs >> $seqres.full
+_qmount_option noquota
_scratch_mount
$here/src/feature -U $SCRATCH_DEV && \
_notrun "UQuota enabled, test needs controlled xfsdump output"
next prev parent reply other threads:[~2019-07-24 15:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 4:12 [PATCH 0/3] fstests: various fixes Darrick J. Wong
2019-07-24 4:12 ` [PATCH 1/3] common: filter aiodio dmesg after fs/iomap.c to fs/iomap/ move Darrick J. Wong
2019-07-24 23:21 ` Dave Chinner
2019-07-25 18:02 ` Darrick J. Wong
2019-07-25 18:03 ` [PATCH v2 " Darrick J. Wong
2019-07-28 11:30 ` Eryu Guan
2019-07-30 0:55 ` Darrick J. Wong
2019-08-07 1:44 ` Darrick J. Wong
2019-08-11 15:25 ` Eryu Guan
2019-07-24 4:13 ` [PATCH 2/3] xfs/504: fix bogus test description Darrick J. Wong
2019-07-24 4:13 ` [PATCH 3/3] generic/561: kill duperemove after sleep_time Darrick J. Wong
2019-07-24 15:55 ` [PATCH 4/3] generic/506: mount scratch fs before testing for prjquota presence Darrick J. Wong
2019-07-24 15:56 ` Darrick J. Wong [this message]
2019-07-24 15:56 ` [PATCH 6/3] xfs/033: filter out root inode nlink repair Darrick J. Wong
2019-07-24 15:56 ` [PATCH 7/3] xfs/194: unmount forced v4 fs during cleanup Darrick J. Wong
2019-07-24 23:22 ` Dave Chinner
2019-07-25 18:03 ` Darrick J. Wong
2019-07-25 18:04 ` [PATCH v2 " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724155610.GF7084@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).