From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: guaneryu@gmail.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 6/3] xfs/033: filter out root inode nlink repair
Date: Wed, 24 Jul 2019 08:56:31 -0700 [thread overview]
Message-ID: <20190724155631.GG7084@magnolia> (raw)
In-Reply-To: <156394156831.1850719.2997473679130010771.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
A couple of releases ago, xfs_repair was patched to set the root inode
link count correctly when messing around with lost inodes. However, the
old xfs_repair remains in the golden output, so remove it and filter the
line so that we don't cause 'new' regressions on old software.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/xfs/033 | 12 ++++++++++--
tests/xfs/033.out.crc | 2 --
tests/xfs/033.out.default | 2 --
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/tests/xfs/033 b/tests/xfs/033
index 75b44f38..0ce67a9c 100755
--- a/tests/xfs/033
+++ b/tests/xfs/033
@@ -91,9 +91,17 @@ src/feature -P $SCRATCH_DEV && \
_notrun "PQuota are enabled, test needs controlled sb recovery"
_scratch_unmount
+# We fixed some bugs in xfs_repair that caused us to have to reset the inode
+# link counts on the root inode twice. That wasn't related to what this test
+# is checking, so remove the nlink reset line from the golden output and filter
+# old xfsprogs to avoid introducing new regressions.
+filter_repair() {
+ sed -e '/resetting inode INO nlinks from 1 to 2/d'
+}
+
# rootino, rbmino, and rsumino are now set (lets blow em away!)
-_check_root_inos 0
-_check_root_inos -1 | _filter_bad_ids
+_check_root_inos 0 | filter_repair
+_check_root_inos -1 | filter_repair | _filter_bad_ids
# success, all done
status=0
diff --git a/tests/xfs/033.out.crc b/tests/xfs/033.out.crc
index 2ab4c432..594060f0 100644
--- a/tests/xfs/033.out.crc
+++ b/tests/xfs/033.out.crc
@@ -30,7 +30,6 @@ reinitializing root directory
- traversal finished ...
- moving disconnected inodes to lost+found ...
Phase 7 - verify and correct link counts...
-resetting inode INO nlinks from 1 to 2
done
Corrupting rt bitmap inode - setting bits to 0
Wrote X.XXKb (value 0x0)
@@ -125,7 +124,6 @@ reinitializing root directory
- traversal finished ...
- moving disconnected inodes to lost+found ...
Phase 7 - verify and correct link counts...
-resetting inode INO nlinks from 1 to 2
done
Corrupting rt bitmap inode - setting bits to -1
Wrote X.XXKb (value 0xffffffff)
diff --git a/tests/xfs/033.out.default b/tests/xfs/033.out.default
index 68bc7810..be297e5a 100644
--- a/tests/xfs/033.out.default
+++ b/tests/xfs/033.out.default
@@ -29,7 +29,6 @@ reinitializing root directory
- traversal finished ...
- moving disconnected inodes to lost+found ...
Phase 7 - verify and correct link counts...
-resetting inode INO nlinks from 1 to 2
done
Corrupting rt bitmap inode - setting bits to 0
Wrote X.XXKb (value 0x0)
@@ -122,7 +121,6 @@ reinitializing root directory
- traversal finished ...
- moving disconnected inodes to lost+found ...
Phase 7 - verify and correct link counts...
-resetting inode INO nlinks from 1 to 2
done
Corrupting rt bitmap inode - setting bits to -1
Wrote X.XXKb (value 0xffffffff)
next prev parent reply other threads:[~2019-07-24 15:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 4:12 [PATCH 0/3] fstests: various fixes Darrick J. Wong
2019-07-24 4:12 ` [PATCH 1/3] common: filter aiodio dmesg after fs/iomap.c to fs/iomap/ move Darrick J. Wong
2019-07-24 23:21 ` Dave Chinner
2019-07-25 18:02 ` Darrick J. Wong
2019-07-25 18:03 ` [PATCH v2 " Darrick J. Wong
2019-07-28 11:30 ` Eryu Guan
2019-07-30 0:55 ` Darrick J. Wong
2019-08-07 1:44 ` Darrick J. Wong
2019-08-11 15:25 ` Eryu Guan
2019-07-24 4:13 ` [PATCH 2/3] xfs/504: fix bogus test description Darrick J. Wong
2019-07-24 4:13 ` [PATCH 3/3] generic/561: kill duperemove after sleep_time Darrick J. Wong
2019-07-24 15:55 ` [PATCH 4/3] generic/506: mount scratch fs before testing for prjquota presence Darrick J. Wong
2019-07-24 15:56 ` [PATCH 5/3] various: disable quotas before running test Darrick J. Wong
2019-07-24 15:56 ` Darrick J. Wong [this message]
2019-07-24 15:56 ` [PATCH 7/3] xfs/194: unmount forced v4 fs during cleanup Darrick J. Wong
2019-07-24 23:22 ` Dave Chinner
2019-07-25 18:03 ` Darrick J. Wong
2019-07-25 18:04 ` [PATCH v2 " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724155631.GG7084@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).