From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:40486 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725909AbfGZGh3 (ORCPT ); Fri, 26 Jul 2019 02:37:29 -0400 Date: Thu, 25 Jul 2019 23:37:29 -0700 From: Christoph Hellwig Subject: Re: [PATCH v2] xfs: fix stack contents leakage in the v1 inumber ioctls Message-ID: <20190726063728.GA316@infradead.org> References: <20190725175346.GF1561054@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190725175346.GF1561054@magnolia> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, Dan Carpenter , Eric Sandeen On Thu, Jul 25, 2019 at 10:53:46AM -0700, Darrick J. Wong wrote: > Explicitly initialize the onstack structures to zero so we don't leak > kernel memory into userspace when converting the in-core inumbers > structure to the v1 inogrp ioctl structure. Add a comment about why we > have to use memset to ensure that the padding holes in the structures > are set to zero. > > Fixes: 5f19c7fc6873351 ("xfs: introduce v5 inode group structure") > Reported-by: Dan Carpenter > Signed-off-by: Darrick J. Wong > --- > v2: add comments, use memset this time Looks good, Reviewed-by: Christoph Hellwig