linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 0/4] xfs: fixes and new tests for bulkstat v5
Date: Sun, 28 Jul 2019 19:26:35 +0800	[thread overview]
Message-ID: <20190728112635.GN7943@desktop> (raw)
In-Reply-To: <156394159426.1850833.16316913520596851191.stgit@magnolia>

Hi XFS folks,

On Tue, Jul 23, 2019 at 09:13:14PM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> Fix some problems introduced by the creation of the V5 bulkstat ioctl,
> and then add some new tests to make sure the new libxfrog bulkstat
> wrappers work fine with both the new v5 ioctl and emulating it with the
> old v1 ioctl.

I may need some help on reviewing this patchset, especially the new
bulkstat tests :) Thanks in advance!

But I'd suggest split the last patch into two patches, one introduces &
uses the new helper, the other one adds new tests. Also, it misses a new
entry in .gitignore file.

Thanks,
Eryu

> 
> If you're going to start using this mess, you probably ought to just
> pull from my git trees, which are linked below.
> 
> This is an extraordinary way to destroy everything.  Enjoy!
> Comments and questions are, as always, welcome.
> 
> --D
> 
> kernel git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=bulkstat-v5
> 
> xfsprogs git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=bulkstat-v5
> 
> fstests git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=bulkstat-v5

  parent reply	other threads:[~2019-07-28 11:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24  4:13 [PATCH 0/4] xfs: fixes and new tests for bulkstat v5 Darrick J. Wong
2019-07-24  4:13 ` [PATCH 1/4] xfs/122: ignore inode geometry structure Darrick J. Wong
2019-07-31 11:43   ` Brian Foster
2019-07-24  4:13 ` [PATCH 2/4] xfs/122: mask wonky ioctls Darrick J. Wong
2019-07-31 11:43   ` Brian Foster
2019-07-24  4:13 ` [PATCH 3/4] xfs/122: add the new v5 bulkstat/inumbers ioctl structures Darrick J. Wong
2019-07-31 11:40   ` Brian Foster
2019-07-31 16:08     ` Darrick J. Wong
2019-07-24  4:13 ` [PATCH 4/4] xfs: test new v5 bulkstat commands Darrick J. Wong
2019-07-31 11:43   ` Brian Foster
2019-07-31 16:44     ` Darrick J. Wong
2019-07-31 17:12       ` Brian Foster
2019-07-28 11:26 ` Eryu Guan [this message]
2019-07-30  0:49   ` [PATCH 0/4] xfs: fixes and new tests for bulkstat v5 Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190728112635.GN7943@desktop \
    --to=guaneryu@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).