From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com ([141.146.126.78]:43228 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbfGaQIz (ORCPT ); Wed, 31 Jul 2019 12:08:55 -0400 Date: Wed, 31 Jul 2019 09:08:32 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 3/4] xfs/122: add the new v5 bulkstat/inumbers ioctl structures Message-ID: <20190731160832.GT1561054@magnolia> References: <156394159426.1850833.16316913520596851191.stgit@magnolia> <156394161274.1850833.4300015313269610610.stgit@magnolia> <20190731114019.GB34040@bfoster> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731114019.GB34040@bfoster> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Brian Foster Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org On Wed, Jul 31, 2019 at 07:40:20AM -0400, Brian Foster wrote: > On Tue, Jul 23, 2019 at 09:13:32PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > The new v5 bulkstat and inumbers structures are correctly padded so that > > no format changes are necessary across platforms, so add them to the > > output. > > > > Signed-off-by: Darrick J. Wong > > --- > > tests/xfs/122.out | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/tests/xfs/122.out b/tests/xfs/122.out > > index cf9ac9e2..e2f346eb 100644 > > --- a/tests/xfs/122.out > > +++ b/tests/xfs/122.out > > @@ -66,6 +66,10 @@ sizeof(struct xfs_btree_block_lhdr) = 64 > > sizeof(struct xfs_btree_block_shdr) = 48 > > sizeof(struct xfs_bud_log_format) = 16 > > sizeof(struct xfs_bui_log_format) = 16 > > +sizeof(struct xfs_bulk_ireq) = 64 > > +sizeof(struct xfs_bulkstat) = 192 > > +sizeof(struct xfs_bulkstat_req) = 64 > > +sizeof(struct xfs_bulkstat_single_req) = 224 > > sizeof(struct xfs_clone_args) = 32 > > sizeof(struct xfs_cud_log_format) = 16 > > sizeof(struct xfs_cui_log_format) = 16 > > @@ -89,6 +93,9 @@ sizeof(struct xfs_fsop_geom_v4) = 112 > > sizeof(struct xfs_icreate_log) = 28 > > sizeof(struct xfs_inode_log_format) = 56 > > sizeof(struct xfs_inode_log_format_32) = 52 > > +sizeof(struct xfs_inumbers) = 24 > > +sizeof(struct xfs_inumbers_req) = 64 > > +sizeof(struct xfs_ireq) = 32 > > I don't see xfs_bulkstat_single_req or xfs_ireq in the latest kernel > headers. Do we still have those? Otherwise looks fine. Ooops, I forgot to remove those, will fix. --D > Brian > > > sizeof(struct xfs_log_dinode) = 176 > > sizeof(struct xfs_map_extent) = 32 > > sizeof(struct xfs_phys_extent) = 16 > >