From: Dave Chinner <david@fromorbit.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: show error code when printing writeback error messages.
Date: Thu, 1 Aug 2019 20:38:51 +1000 [thread overview]
Message-ID: <20190801103851.GL7777@dread.disaster.area> (raw)
In-Reply-To: <1564653826-8916-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
On Thu, Aug 01, 2019 at 07:03:46PM +0900, Tetsuo Handa wrote:
> Even without backtraces, including error code should be helpful.
>
> [ 630.162595][ T9218] XFS (sda1): writeback error -12 on sector 131495992
> [ 631.718685][ T9432] XFS (sda1): writeback error -12 on sector 131503928
> [ 632.015588][ T442] XFS (sda1): writeback error -12 on sector 157773936
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> ---
> fs/xfs/xfs_aops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index f16d5f196c6b..d2c9076643cf 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -112,7 +112,7 @@ xfs_destroy_ioend(
>
> if (unlikely(error && !quiet)) {
> xfs_err_ratelimited(XFS_I(inode)->i_mount,
> - "writeback error on sector %llu", start);
> + "writeback error %d on sector %llu", error, start);
If you are going to do this, make the error message properly useful.
Report the inode number and the ioend offset and length so we know
what file and where in the file the writeback failure occurred.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-08-01 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 10:03 [PATCH] xfs: show error code when printing writeback error messages Tetsuo Handa
2019-08-01 10:38 ` Dave Chinner [this message]
2019-08-26 19:01 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801103851.GL7777@dread.disaster.area \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox