From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Brian Foster <bfoster@redhat.com>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 5/5] xfs: test new v5 bulkstat commands
Date: Thu, 1 Aug 2019 07:01:46 -0700 [thread overview]
Message-ID: <20190801140146.GC1561054@magnolia> (raw)
In-Reply-To: <20190801104814.GC59093@bfoster>
On Thu, Aug 01, 2019 at 06:48:15AM -0400, Brian Foster wrote:
> On Wed, Jul 31, 2019 at 06:43:10PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Check that the new v5 bulkstat commands do everything the old one do,
> > and then make sure the new functionality actually works.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > .gitignore | 1
> > src/Makefile | 2
> > src/bulkstat_null_ocount.c | 61 +++++++++
> > tests/xfs/744 | 215 ++++++++++++++++++++++++++++++++
> > tests/xfs/744.out | 297 ++++++++++++++++++++++++++++++++++++++++++++
> > tests/xfs/745 | 47 +++++++
> > tests/xfs/745.out | 2
> > tests/xfs/group | 2
> > 8 files changed, 626 insertions(+), 1 deletion(-)
> > create mode 100644 src/bulkstat_null_ocount.c
> > create mode 100755 tests/xfs/744
> > create mode 100644 tests/xfs/744.out
> > create mode 100755 tests/xfs/745
> > create mode 100644 tests/xfs/745.out
> >
> >
> ...
> > diff --git a/tests/xfs/group b/tests/xfs/group
> > index 270d82ff..ef0cf92c 100644
> > --- a/tests/xfs/group
> > +++ b/tests/xfs/group
> > @@ -506,3 +506,5 @@
> > 506 auto quick health
> > 507 clone
> > 508 auto quick quota
> > +744 auto ioctl quick
> > +745 auto ioctl quick
> >
>
> One quick note that xfs/744 runs in ~68 seconds in my (low resource)
> test VM. Not a problem in and of itself, but it seems slightly long for
> the quick group. Can somebody remind me of the quick group criteria?
>
> FWIW if I kick off a quick group run, the first 10-15 tests complete in
> 10s or so or less with the exception of generic/013, which takes over a
> minute. So perhaps anything under a minute or so is fine..? Either way,
> that can be easily changed on merge if appropriate:
Hmm, yeah, that's probably too slow for quick...
> Reviewed-by: Brian Foster <bfoster@redhat.com>
Thanks for the review!
--D
next prev parent reply other threads:[~2019-08-01 14:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 1:42 [PATCH v2 0/5] xfs: fixes and new tests for bulkstat v5 Darrick J. Wong
2019-08-01 1:42 ` [PATCH 1/5] xfs/122: ignore inode geometry structure Darrick J. Wong
2019-08-01 1:42 ` [PATCH 2/5] xfs/122: mask wonky ioctls Darrick J. Wong
2019-08-01 1:42 ` [PATCH 3/5] xfs/122: add the new v5 bulkstat/inumbers ioctl structures Darrick J. Wong
2019-08-01 10:47 ` Brian Foster
2019-08-01 1:43 ` [PATCH 4/5] common/xfs: refactor agcount calculation for mounted filesystems Darrick J. Wong
2019-08-01 10:48 ` Brian Foster
2019-08-01 1:43 ` [PATCH 5/5] xfs: test new v5 bulkstat commands Darrick J. Wong
2019-08-01 10:48 ` Brian Foster
2019-08-01 14:01 ` Darrick J. Wong [this message]
2019-08-02 1:55 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801140146.GC1561054@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).