From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:53237 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbfHFFdn (ORCPT ); Tue, 6 Aug 2019 01:33:43 -0400 Date: Tue, 6 Aug 2019 07:33:39 +0200 From: Christoph Hellwig Subject: Re: [PATCH 2/6] iomap: copy the xfs writeback code to iomap.c Message-ID: <20190806053339.GF13409@lst.de> References: <156444945993.2682261.3926017251626679029.stgit@magnolia> <156444947277.2682261.14371480217831737439.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Andreas Gruenbacher Cc: "Darrick J. Wong" , Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel , Damien Le Moal , Christoph Hellwig Hi Andreas, any chance you could trim your quote to the relevant parts? On Sun, Aug 04, 2019 at 04:59:25PM +0200, Andreas Gruenbacher wrote: > > + /* > > + * File systems can perform actions at submit time and/or override > > + * the end_io handler here for complex operations like copy on write > > + * extent manipulation or unwritten extent conversions. > > + */ > > + if (wpc->ops->submit_ioend) > > + error = wpc->ops->submit_ioend(ioend, error); > > I think we only want to call submit_ioend here if error isn't set already. No, we need to call it even with an error so that the file system can override the bi_end_io handler, which bio_endio ends up calling even for the error case. Maybe the comment above could use an update to make that more clear.