Re: [PATCH] [Regression, v5.0] mm: boosted kswapd reclaim b0rks system cache balance

Mel Gorman
2019-08-08T17:04:40Z

On Thu, Aug 08, 2019 at 08:36:58AM -0700, Christoph Hellwig wrote:
> > - if (sc->may_shrinkslab) {
> > - shrink_slab(sc->gfp_mask, pgdat->node_id,
> > - memcg, sc->priority);
> > - }
> > + shrink_slab(sc->gfp_mask, pgdat->node_id,
> > + memcg, sc->priority);
>
> Not the most useful comment, but the indentation for the continuing line
> is weird (already in the original code). This should be something like:
>
> shrink_slab(sc->gfp_mask, pgdat->node_id, memcg,
> sc->priority);

If that's the worst you found then I take it as good news. I have not
sent a version with an updated changelog so I can fix it up.

--
Mel Gorman
SUSE Labs