From: Allison Collins <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v1 17/19] xfsprogs: Enable delayed attributes
Date: Fri, 9 Aug 2019 14:38:02 -0700 [thread overview]
Message-ID: <20190809213804.32628-18-allison.henderson@oracle.com> (raw)
In-Reply-To: <20190809213804.32628-1-allison.henderson@oracle.com>
Finally enable delayed attributes in xfs_attr_set and
xfs_attr_remove. We only do this for v4 and up since we
cant add new log entries to old fs versions
Signed-off-by: Allison Collins <allison.henderson@oracle.com>
---
libxfs/xfs_attr.c | 26 ++++++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c
index ecc525c..dc38715 100644
--- a/libxfs/xfs_attr.c
+++ b/libxfs/xfs_attr.c
@@ -507,6 +507,7 @@ xfs_attr_set(
int valuelen)
{
struct xfs_mount *mp = dp->i_mount;
+ struct xfs_sb *sbp = &mp->m_sb;
struct xfs_da_args args;
struct xfs_trans_res tres;
int rsvd = (name->type & ATTR_ROOT) != 0;
@@ -565,7 +566,20 @@ xfs_attr_set(
goto out_trans_cancel;
xfs_trans_ijoin(args.trans, dp, 0);
- error = xfs_attr_set_args(&args);
+ if (XFS_SB_VERSION_NUM(sbp) < XFS_SB_VERSION_4)
+ error = xfs_attr_set_args(&args);
+ else {
+ error = xfs_has_attr(&args);
+
+ if (error == -EEXIST && (name->type & ATTR_CREATE))
+ goto out_trans_cancel;
+
+ if (error == -ENOATTR && (name->type & ATTR_REPLACE))
+ goto out_trans_cancel;
+
+ error = xfs_attr_set_deferred(dp, args.trans, name, value,
+ valuelen);
+ }
if (error)
goto out_trans_cancel;
if (!args.trans) {
@@ -650,6 +664,7 @@ xfs_attr_remove(
struct xfs_name *name)
{
struct xfs_mount *mp = dp->i_mount;
+ struct xfs_sb *sbp = &mp->m_sb;
struct xfs_da_args args;
int error;
@@ -691,7 +706,14 @@ xfs_attr_remove(
*/
xfs_trans_ijoin(args.trans, dp, 0);
- error = xfs_attr_remove_args(&args);
+ error = xfs_has_attr(&args);
+ if (error == -ENOATTR)
+ goto out;
+
+ if (XFS_SB_VERSION_NUM(sbp) < XFS_SB_VERSION_4)
+ error = xfs_attr_remove_args(&args);
+ else
+ error = xfs_attr_remove_deferred(dp, args.trans, name);
if (error)
goto out;
--
2.7.4
next prev parent reply other threads:[~2019-08-09 21:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 21:37 [PATCH v1 00/19] Delayed Attributes Allison Collins
2019-08-09 21:37 ` [PATCH v1 01/19] xfsprogs: Remove all strlen in all xfs_attr_* functions for attr names Allison Collins
2019-08-09 21:37 ` [PATCH v1 02/19] xfsprog: Replace attribute parameters with struct xfs_name Allison Collins
2019-08-09 21:37 ` [PATCH v1 03/19] xfsprogs: Set up infastructure for deferred attribute operations Allison Collins
2019-08-09 21:37 ` [PATCH v1 04/19] xfsprogs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Collins
2019-08-09 21:37 ` [PATCH v1 05/19] xfsprogs: Add xfs_has_attr and subroutines Allison Collins
2019-08-09 21:37 ` [PATCH v1 06/19] xfsprogs: Factor out new helper functions xfs_attr_rmtval_set Allison Collins
2019-08-09 21:37 ` [PATCH v1 07/19] xfsprogs: Factor up trans handling in xfs_attr3_leaf_flipflags Allison Collins
2019-08-09 21:37 ` [PATCH v1 08/19] xfsprogs: Factor out xfs_attr_leaf_addname helper Allison Collins
2019-08-09 21:37 ` [PATCH v1 09/19] xfsprogs: Factor up commit from xfs_attr_try_sf_addname Allison Collins
2019-08-09 21:37 ` [PATCH v1 10/19] xfsprogs: Factor up trans roll from xfs_attr3_leaf_setflag Allison Collins
2019-08-09 21:37 ` [PATCH v1 11/19] xfsprogs: Add xfs_attr3_leaf helper functions Allison Collins
2019-08-09 21:37 ` [PATCH v1 12/19] xfsprogs: Factor out xfs_attr_rmtval_remove_value Allison Collins
2019-08-09 21:37 ` [PATCH v1 13/19] xfsprogs: Factor up trans roll in xfs_attr3_leaf_clearflag Allison Collins
2019-08-09 21:37 ` [PATCH v1 14/19] xfsprogs: Add delay context to xfs_da_args Allison Collins
2019-08-09 21:38 ` [PATCH v1 15/19] xfsprogs: Add delayed attribute routines Allison Collins
2019-08-09 21:38 ` [PATCH v1 16/19] xfsprogs: Roll delayed attr operations by returning EAGAIN Allison Collins
2019-08-09 21:38 ` Allison Collins [this message]
2019-08-09 21:38 ` [PATCH v1 18/19] xfsprogs: Add delayed attributes error tag Allison Collins
2019-08-12 16:44 ` Darrick J. Wong
2019-08-12 22:39 ` Allison Collins
2019-08-09 21:38 ` [PATCH v1 19/19] xfsprogs: Add log item printing for ATTRI and ATTRD Allison Collins
2019-08-12 16:46 ` Darrick J. Wong
2019-08-12 23:34 ` Allison Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809213804.32628-18-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox