Re: [PATCH v1 18/19] xfsprogs: Add delayed attributes error tag

Allison Collins
2019-08-12T22:41:30Z

On 8/12/19 9:44 AM, Darrick J. Wong wrote:
> On Fri, Aug 09, 2019 at 02:38:03PM -0700, Allison Collins wrote:
>> Subject: [PATCH v1 18/19] xfsprogs: Add delayed attributes error tag
>
> In the final version this ought to be "xfs_io:", not "xfsprogs:" since
> the libxfs changes will invariably land through a separate
> libxfs-apply'd patch.
>
> Looks ok otherwise,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>

Ok, will do. Thanks!
Allison

> --D
>
>> This patch adds an error tag that we can use to test
>> delayed attribute recovery and replay
>>
>> Signed-off-by: Allison Collins <allison.henderson@oracle.com>
>> ---
>> io/inject.c | 1 +
>> libxfs/xfs_errortag.h | 4 +++-
>> 2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/io/inject.c b/io/inject.c
>> index cabfc3e..05bd4db 100644
>> --- a/io/inject.c
>> +++ b/io/inject.c
>> @@ -54,6 +54,7 @@ error_tag(char *name)
>> { XFS_ERRTAG_FORCE_SCRUB_REPAIR, "force_repair" },
>> { XFS_ERRTAG_FORCE_SUMMARY_RECALC, "bad_summary" },
>> { XFS_ERRTAG_IUNLINK_FALLBACK, "iunlink_fallback" },
>> + { XFS_ERRTAG_DELAYED_ATTR, "delayed_attr" },
>> { XFS_ERRTAG_MAX, NULL }
>> };
>> int count;
>> diff --git a/libxfs/xfs_errortag.h b/libxfs/xfs_errortag.h
>> index 79e6c4f..85d5850 100644
>> --- a/libxfs/xfs_errortag.h
>> +++ b/libxfs/xfs_errortag.h
>> @@ -55,7 +55,8 @@
>> #define XFS_ERRTAG_FORCE_SCRUB_REPAIR 32
>> #define XFS_ERRTAG_FORCE_SUMMARY_RECALC 33
>> #define XFS_ERRTAG_IUNLINK_FALLBACK 34
>> -#define XFS_ERRTAG_MAX 35
>> +#define XFS_ERRTAG_DELAYED_ATTR 35
>> +#define XFS_ERRTAG_MAX 36
>>
>> /*
>> * Random factors for above tags, 1 means always, 2 means 1/2 time, etc.
>> @@ -95,5 +96,6 @@
>> #define XFS_RANDOM_FORCE_SCRUB_REPAIR 1
>> #define XFS_RANDOM_FORCE_SUMMARY_RECALC 1
>> #define XFS_RANDOM_IUNLINK_FALLBACK (XFS_RANDOM_DEFAULT/10)
>> +#define XFS_RANDOM_DELAYED_ATTR 1
>>
>> #endif /* __XFS_ERRORTAG_H_ */
>> --
>> 2.7.4
>>