Re: xfsprogs-5.2.0 FTBFS: ../libxfs/.libs/libxfs.so: undefined reference to `xfs_ag_geom_health'

Eric Sandeen
2019-08-12T16:35:00Z

[-- Attachment #1.1: Type: text/plain, Size: 1656 bytes --]

On 8/12/19 5:57 AM, Thomas Deutschmann wrote:
> Hi,
>
> On 2019-08-12 06:30, Dave Chinner wrote:
>>>> In a clear environment, do:
>>>>
>>>>> tar -xaf xfsprogs-5.2.0.tar.xz
>>>>> cd xfsprogs-5.2.0
>>>>> export CFLAGS="-O2 -pipe -march=ivybridge -mtune=ivybridge -mno-xsaveopt"
>>>>> export LDFLAGS="-Wl,-O1 -Wl,--as-needed"
>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>> Don't do this.
>>>
>>> "--as-needed" is the default linker behaviour since gcc 4.x. You do
>>> not need this. As for passing "-O1" to the linker, that's not going
>>> to do anything measurable for you. Use --enable-lto to turn on link
>>> time optimisations if they are supported by the compiler.
>>
>> Ok, I could reproduce your link time failure for a while with
>> --enable-lto, but I ran 'make distclean' and the problem went away
>> completely. And I can build with your options successfully, too:
>>
>> $ make realclean
>> $ make configure
>> <builds new configure script>
>> $ LDFLAGS="-Wl,-O1 -Wl,--as-needed" ./configure
>
> That's not the correct way to reproduce. It's really important to
> _export_ the variable to trigger the problem and _this_ is a problem in
> xfsprogs' build system.
>
> But keep in mind that 3x "-Wl,-O1 -Wl,--as-needed" don't cause a failure
> without "--disable-static" for me... that's just the answer for your
> question where this is coming from.

My takeaway here is that I should probably stub out some things to make
this issue go away altogether, but that it can also be remedied by adjusting
compiler/linker flags. Correct? I'm not sure if this warrants a 5.2.1 release.

Thanks,
-Eric

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 873 bytes --]