Re: xfsprogs-5.2.0 FTBFS: ../libxfs/.libs/libxfs.so: undefined reference to `xfs_ag_geom_health'

Thomas Deutschmann
2019-08-12T22:18:15Z

[-- Attachment #1.1: Type: text/plain, Size: 1340 bytes --]

On 2019-08-12 23:44, Dave Chinner wrote:
>> That's not the correct way to reproduce. It's really important to
>> _export_ the variable to trigger the problem and _this_ is a problem in
>> xfsprogs' build system.
> Which means you are overriding the LDFLAGS set by configure when
> you _run make_, not just telling configure to use those LDFLAGS.
>
> That's why _make_ is getting screwed up - it is doing exactly what
> you are telling it to do, and that is to overrides every occurrence
> of LDFLAGS with your exported options rather than using the correct
> set configure calculated and specified.
>
> Exporting your CFLAGS and LDFLAGS is the wrong thing to doing
> - they should only ever be passed to the configure invocation and
> not remain to pollute the build environment after you've run
> configure.

I disagree with the conclusion. LDFLAGS in build environment shouldn't
cause any problems, especially when you are using a build system:

Normally, configure will get the value and the Makefiles will use the
value _from_ configure... but using configure _and_ reading _and adding_
values from environment _in addition_ seems to be wrong.

So you either use a build system or you don't.

--
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 618 bytes --]