From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:42810 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726352AbfHOMQZ (ORCPT ); Thu, 15 Aug 2019 08:16:25 -0400 Date: Thu, 15 Aug 2019 22:15:12 +1000 From: Dave Chinner Subject: Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr() Message-ID: <20190815121511.GR6129@dread.disaster.area> References: <20190814204259.120942-1-arnd@arndb.de> <20190814204259.120942-2-arnd@arndb.de> <20190814213753.GP6129@dread.disaster.area> <20190815071314.GA6960@infradead.org> <20190815080211.GA17055@infradead.org> <20190815102649.GA10821@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190815102649.GA10821@infradead.org> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: Arnd Bergmann , Linux Kernel Mailing List , Al Viro , Linux FS-devel Mailing List , "Darrick J. Wong" , linux-xfs , Brian Foster , Allison Collins , Nick Bowler , Eric Sandeen , Dave Chinner On Thu, Aug 15, 2019 at 03:26:49AM -0700, Christoph Hellwig wrote: > On Thu, Aug 15, 2019 at 01:02:11AM -0700, Christoph Hellwig wrote: > > In many ways I'd actually much rather have a table driven approach. > > Let me try something.. > > Ok, it seems like we don't even need a table containing native and > compat as we can just fall back. The tables still seem nicer to read, > though. > > Let me know what you think of this: > > http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xfs-ioctl-table Lots to like in that handful of patches. :) It can easily go before or after Arnd's patch, and the merge conflict either way would be minor, so I'm not really fussed either way this gets sorted out... Cheers, Dave. -- Dave Chinner david@fromorbit.com