Re: [PATCH 3/3] xfs: alignment check bio buffers

Dave Chinner
2019-08-22T10:18:14Z

On Thu, Aug 22, 2019 at 01:03:12AM -0700, Christoph Hellwig wrote:
> On Thu, Aug 22, 2019 at 10:37:45AM +1000, Dave Chinner wrote:
> > > I know Jens disagree, but with the amount of bugs we've been hitting
> > > thangs to slub (and I'm pretty sure we have a more hiding outside of
> > > XFS) I think we need to add the blk_rq_aligned check to bio_add_page.
> >
> > ... I'm not prepared to fight this battle to get this initial fix
> > into the code. Get the fix merged, then we can
>
> Well, the initial fix are the first two patches. This patch really
> just adds a safety belt. I'll happily take over the effort to get
> sensible checks in the block code if you give me a couple weeks,
> in the meantime I'd prefer if we could skip this third patch for now.

Fine by me. I'll just repost the current versions of the first two
patches (now three) in the morning.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com