Re: [PATCH v2 1/5] fs: Introduce i_blocks_per_page

Matthew Wilcox
2019-09-18T23:48:37Z

On Wed, Sep 18, 2019 at 02:14:39PM -0700, Darrick J. Wong wrote:
> On Tue, Aug 20, 2019 at 05:30:35PM -0700, Matthew Wilcox wrote:
> > From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> >
> > This helper is useful for both large pages in the page cache and for
> > supporting block size larger than page size. Convert some example
> > users (we have a few different ways of writing this idiom).
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> Seems pretty straightforward, modulo whatever's going on with the kbuild
> robot complaint (is there something wrong, or is it just that obnoxious
> header check thing?)

It doesn't apply patches on top of the -mm tree for some reason. So
it has no idea about the page_size() macro that's sitting in -mm at the
moment.

> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

Thanks.