Re: [PATCH v2 2/5] mm: Add file_offset_of_ helpers

kbuild test robot
2019-08-24T11:49:06Z

[-- Attachment #1: Type: text/plain, Size: 2284 bytes --]

Hi Matthew,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc5 next-20190823]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox/iomap-xfs-support-for-large-pages/20190823-191138
config: x86_64-randconfig-f001-201933 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from arch/x86/include/asm/pgalloc.h:7:0,
from include/asm-generic/tlb.h:16,
from arch/x86/include/asm/tlb.h:12,
from arch/x86/include/asm/efi.h:8,
from drivers/firmware/efi/libstub/tpm.c:12:
include/linux/pagemap.h: In function 'file_offset_of_next_page':
>> include/linux/pagemap.h:445:32: warning: implicit declaration of function 'compound_nr'; did you mean 'compound_order'? [-Wimplicit-function-declaration]
return ((loff_t)page->index + compound_nr(page)) << PAGE_SHIFT;
^~~~~~~~~~~
compound_order
include/linux/pagemap.h: In function 'i_blocks_per_page':
include/linux/pagemap.h:659:9: warning: implicit declaration of function 'page_size'; did you mean 'page_zone'? [-Wimplicit-function-declaration]
return page_size(page) >> inode->i_blkbits;
^~~~~~~~~
page_zone

vim +445 include/linux/pagemap.h

435
436 /**
437 * file_offset_of_next_page - File offset of the next page.
438 * @page: Page cache page.
439 *
440 * Context: Any context.
441 * Return: The offset of the first byte after this page.
442 */
443 static inline loff_t file_offset_of_next_page(struct page *page)
444 {
> 445 return ((loff_t)page->index + compound_nr(page)) << PAGE_SHIFT;
446 }
447

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31936 bytes --]