From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dave Chinner <david@fromorbit.com>,
Salvatore Bonaccorso <carnil@debian.org>,
Security Officers <security@kernel.org>,
Debian Security Team <team@security.debian.org>,
benjamin.moody@gmail.com, Ben Hutchings <benh@debian.org>,
Christoph Hellwig <hch@infradead.org>,
fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] generic: test for failure to unlock inode after chgrp fails with EDQUOT
Date: Sat, 24 Aug 2019 16:05:50 -0700 [thread overview]
Message-ID: <20190824230550.GA5494@infradead.org> (raw)
In-Reply-To: <20190823035734.GH1037350@magnolia>
> diff --git a/tests/generic/group b/tests/generic/group
> index e998d1d5..bb93bccc 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -572,3 +572,4 @@
> 716 dangerous_norepair
> 717 auto quick rw swap
> 718 auto quick rw swap
> +719 dangerous
+ quota + metadata?
Otherwise this looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
and after a while we should add it to auto. I'm not even sure if we
shouldn't do that ASAP. It's not that dangerous and we should test
for this everywhere..
next prev parent reply other threads:[~2019-08-24 23:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 3:55 [PATCH] xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT Darrick J. Wong
2019-08-23 3:57 ` [PATCH] generic: test for failure to unlock inode after chgrp fails with EDQUOT Darrick J. Wong
2019-08-24 23:05 ` Christoph Hellwig [this message]
2019-08-23 4:55 ` [PATCH] xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT Dave Chinner
2019-08-23 16:28 ` Linus Torvalds
2019-08-23 17:15 ` Benjamin Moody
2019-08-23 19:26 ` Salvatore Bonaccorso
2019-08-24 18:22 ` Salvatore Bonaccorso
2019-08-23 19:24 ` Salvatore Bonaccorso
2019-08-24 18:44 ` Linus Torvalds
2019-08-25 3:13 ` Greg KH
2019-08-25 15:45 ` Salvatore Bonaccorso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824230550.GA5494@infradead.org \
--to=hch@infradead.org \
--cc=benh@debian.org \
--cc=benjamin.moody@gmail.com \
--cc=carnil@debian.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=security@kernel.org \
--cc=team@security.debian.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox