public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Salvatore Bonaccorso <carnil@debian.org>
To: Greg KH <greg@kroah.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	xfs <linux-xfs@vger.kernel.org>,
	Dave Chinner <david@fromorbit.com>,
	Security Officers <security@kernel.org>,
	Debian Security Team <team@security.debian.org>,
	benjamin.moody@gmail.com, Ben Hutchings <benh@debian.org>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT
Date: Sun, 25 Aug 2019 17:45:25 +0200	[thread overview]
Message-ID: <20190825154525.GC14904@eldamar.local> (raw)
In-Reply-To: <20190825031318.GB2590@kroah.com>

Hi Greg,

On Sun, Aug 25, 2019 at 05:13:18AM +0200, Greg KH wrote:
> On Sat, Aug 24, 2019 at 11:44:44AM -0700, Linus Torvalds wrote:
> > On Fri, Aug 23, 2019 at 12:24 PM Salvatore Bonaccorso <carnil@debian.org> wrote:
> > >
> > > Confirmed the fix work.
> > >
> > > Feel free to add a Tested-by if wanted.
> > >
> > > Can this be backported to the relevant stable versions as well?
> > 
> > It's out there in my tree now. It's not explicitly marked for stable
> > per se, but it does have the "Fixes:" tag which should mean that Greg
> > and Sasha will pick it up automatically.
> > 
> > But just to make it explicit, since Greg is on the security list,
> > Darrick's fix is commit 1fb254aa983b ("xfs: fix missing ILOCK unlock
> > when xfs_setattr_nonsize fails due to EDQUOT").
> 
> Thanks, I'll pick this up.
> 
> Note, "Fixes:" will never guarantee that a patch ends up in a stable
> release.  Sasha's scripts usually do a good job of catching a lot of
> them a week or so after-the-fact, but they are not guaranteed to do so.
> A CC: stable@ will always be caught by me, and I try to ensure that
> anything goes across the security@k.o list also gets picked up.

Thank you.

FTR, for those interested in tracking this fix for the DoS potential
as vulnerability, MITRE has assigned CVE-2019-15538 for this issue.

Regards,
Salvatore

      reply	other threads:[~2019-08-25 15:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  3:55 [PATCH] xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT Darrick J. Wong
2019-08-23  3:57 ` [PATCH] generic: test for failure to unlock inode after chgrp fails with EDQUOT Darrick J. Wong
2019-08-24 23:05   ` Christoph Hellwig
2019-08-23  4:55 ` [PATCH] xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT Dave Chinner
2019-08-23 16:28 ` Linus Torvalds
2019-08-23 17:15   ` Benjamin Moody
2019-08-23 19:26   ` Salvatore Bonaccorso
2019-08-24 18:22     ` Salvatore Bonaccorso
2019-08-23 19:24 ` Salvatore Bonaccorso
2019-08-24 18:44   ` Linus Torvalds
2019-08-25  3:13     ` Greg KH
2019-08-25 15:45       ` Salvatore Bonaccorso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190825154525.GC14904@eldamar.local \
    --to=carnil@debian.org \
    --cc=benh@debian.org \
    --cc=benjamin.moody@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=greg@kroah.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=team@security.debian.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox