From: Dave Chinner <david@fromorbit.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v2] xfs: use aligned buffers for IO
Date: Mon, 26 Aug 2019 11:40:04 +1000 [thread overview]
Message-ID: <20190826014007.10877-1-david@fromorbit.com> (raw)
Hi folks,
This is an updated version of the patchset originally posted here:
https://lore.kernel.org/linux-xfs/20190821083820.11725-1-david@fromorbit.com/T/#t
It intends to avoid th eproblems of IO being silently corrupted
by drivers when kernel memory debugging options are turned on due
to changes in heap allocated object alignment. Full description is
in the link above.
Changes in V2
- dropped xfs_add_bio_page() validation wrapper. Contentious,
Christoph will look to adding it into the generic block layer
code.
- added xfs_buftarg_dma_alignment() to grab the alignment from the
current device we are allocating a buffer for.
- feed the correct alignment for the underlying device into
kmem_alloc_io() to minimise the occurrence of failed alignment for
devices that support fine-grained alignment.
- kmem_alloc_io() supports alignment up to page size and will warn if
any alignment greater than a page is requested. Devices that
require larger than page alignment should not exist.
Cheers,
Dave.
next reply other threads:[~2019-08-26 1:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 1:40 Dave Chinner [this message]
2019-08-26 1:40 ` [PATCH 1/3] xfs: add kmem allocation trace points Dave Chinner
2019-08-26 7:47 ` Christoph Hellwig
2019-08-26 1:40 ` [PATCH 2/3] xfs: get allocation alignment from the buftarg Dave Chinner
2019-08-26 7:48 ` Christoph Hellwig
2019-08-26 1:40 ` [PATCH 3/3] xfs: add kmem_alloc_io() Dave Chinner
2019-08-26 7:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826014007.10877-1-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox