Re: [PATCH 2/5] xfs: factor data block addition from xfs_dir2_node_addname_int()

Dave Chinner
2019-08-29T08:34:52Z

On Thu, Aug 29, 2019 at 01:05:29AM -0700, Christoph Hellwig wrote:
> On Thu, Aug 29, 2019 at 04:30:39PM +1000, Dave Chinner wrote:
> > + XFS_ERROR_REPORT("xfs_dir2_node_addname_int",
> > + XFS_ERRLEVEL_LOW, mp);
>
> The function name here is incorret now. I'd say just use __func__
> to avoid that for the future.

Fixed.

> Otherwise some of the code flow in the caller looks very ugly just with
> this patch, but given that it is all sorted out by the end of the series
> I don't really see an issue.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks.

-Dave.
--
Dave Chinner
david@fromorbit.com