Re: [PATCH 3/5] xfs: factor free block index lookup from xfs_dir2_node_addname_int()

Christoph Hellwig
2019-08-29T08:18:24Z

On Thu, Aug 29, 2019 at 04:30:40PM +1000, Dave Chinner wrote:
> + /*
> + * Now we know if we must allocate blocks, so if we are checking whether
> + * we can insert without allocation then we can return now.
> + */
> + if (args->op_flags & XFS_DA_OP_JUSTCHECK) {
> + if (dbno != -1)
> + return 0;
> + return -ENOSPC;
> + }

Nit: I'd invert the check to rturn -ENOSPC in the branch if dbno is
-1 to make the flow a littler easier.

Otherwise this looks great and makes the code much easier to read:

Reviewed-by: Christoph Hellwig <hch@lst.de>