From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 11/12] xfs_repair: use precomputed inode geometry values
Date: Fri, 30 Aug 2019 16:17:34 +1000 [thread overview]
Message-ID: <20190830061734.GM1119@dread.disaster.area> (raw)
In-Reply-To: <156633314305.1215978.18190917724979571824.stgit@magnolia>
On Tue, Aug 20, 2019 at 01:32:23PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Use the precomputed inode geometry values instead of open-coding them.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> repair/dino_chunks.c | 22 +++++++++++-----------
> repair/dinode.c | 13 ++++---------
> repair/globals.c | 1 -
> repair/globals.h | 1 -
> repair/prefetch.c | 21 ++++++++-------------
> repair/xfs_repair.c | 2 --
> 6 files changed, 23 insertions(+), 37 deletions(-)
two minor nits:
> diff --git a/repair/prefetch.c b/repair/prefetch.c
> index 2fecfd68..5a725a51 100644
> --- a/repair/prefetch.c
> +++ b/repair/prefetch.c
> @@ -710,17 +710,12 @@ pf_queuing_worker(
> int num_inos;
> ino_tree_node_t *irec;
> ino_tree_node_t *cur_irec;
> - int blks_per_cluster;
> xfs_agblock_t bno;
> int i;
> int err;
> uint64_t sparse;
> struct xfs_ino_geometry *igeo = M_IGEO(mp);
>
> - blks_per_cluster = igeo->inode_cluster_size >> mp->m_sb.sb_blocklog;
> - if (blks_per_cluster == 0)
> - blks_per_cluster = 1;
> -
> for (i = 0; i < PF_THREAD_COUNT; i++) {
> err = pthread_create(&args->io_threads[i], NULL,
> pf_io_worker, args);
> @@ -786,21 +781,22 @@ pf_queuing_worker(
> struct xfs_buf_map map;
>
> map.bm_bn = XFS_AGB_TO_DADDR(mp, args->agno, bno);
> - map.bm_len = XFS_FSB_TO_BB(mp, blks_per_cluster);
> + map.bm_len = XFS_FSB_TO_BB(mp,
> + M_IGEO(mp)->blocks_per_cluster);
igeo->blocks_per_cluster
>
> /*
> * Queue I/O for each non-sparse cluster. We can check
> * sparse state in cluster sized chunks as cluster size
> * is the min. granularity of sparse irec regions.
> */
> - if ((sparse & ((1ULL << inodes_per_cluster) - 1)) == 0)
> + if ((sparse & ((1ULL << M_IGEO(mp)->inodes_per_cluster) - 1)) == 0)
igeo->inodes_per_cluster and 80 columns....
Otherwise,
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-08-30 6:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 20:31 [PATCH 00/12] xfsprogs-5.3: various fixes Darrick J. Wong
2019-08-20 20:31 ` [PATCH 01/12] libxfs-diff: try harder to find the kernel equivalent libxfs files Darrick J. Wong
2019-08-30 5:38 ` Dave Chinner
2019-08-30 5:40 ` Darrick J. Wong
2019-08-20 20:31 ` [PATCH 02/12] libxfs: move topology declarations into separate header Darrick J. Wong
2019-08-30 5:43 ` Dave Chinner
2019-08-30 20:34 ` Darrick J. Wong
2019-09-02 22:33 ` Dave Chinner
2019-09-03 3:16 ` Darrick J. Wong
2019-09-03 17:15 ` Darrick J. Wong
2019-08-20 20:31 ` [PATCH 03/12] libfrog: try the v4 fs geometry ioctl after failing the v5 ioctl Darrick J. Wong
2019-08-30 5:43 ` Dave Chinner
2019-08-20 20:31 ` [PATCH 04/12] man: document the new v5 fs geometry ioctl structures Darrick J. Wong
2019-08-30 5:44 ` Dave Chinner
2019-08-30 20:40 ` Darrick J. Wong
2019-08-20 20:31 ` [PATCH 05/12] man: document new fs summary counter scrub command Darrick J. Wong
2019-08-30 5:45 ` Dave Chinner
2019-08-20 20:31 ` [PATCH 06/12] man: document the new allocation group geometry ioctl Darrick J. Wong
2019-08-30 5:53 ` Dave Chinner
2019-08-30 20:48 ` Darrick J. Wong
2019-09-02 22:36 ` Dave Chinner
2019-09-03 3:22 ` Darrick J. Wong
2019-08-20 20:31 ` [PATCH 07/12] man: document the new health reporting fields in various ioctls Darrick J. Wong
2019-08-30 5:57 ` Dave Chinner
2019-08-20 20:32 ` [PATCH 08/12] xfs_db: remove db/convert.h Darrick J. Wong
2019-08-30 5:58 ` Dave Chinner
2019-08-20 20:32 ` [PATCH 09/12] xfs_db: add a function to compute btree geometry Darrick J. Wong
2019-08-30 6:12 ` Dave Chinner
2019-08-20 20:32 ` [PATCH 10/12] xfs_db: use precomputed inode geometry values Darrick J. Wong
2019-08-30 6:13 ` Dave Chinner
2019-08-20 20:32 ` [PATCH 11/12] xfs_repair: " Darrick J. Wong
2019-08-30 6:17 ` Dave Chinner [this message]
2019-08-30 20:52 ` Darrick J. Wong
2019-08-20 20:32 ` [PATCH 12/12] xfs_repair: reduce the amount of "clearing reflink flag" messages Darrick J. Wong
2019-08-30 6:19 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830061734.GM1119@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox