From: Dave Chinner <david@fromorbit.com>
To: Austin Kim <austindh.kim@gmail.com>
Cc: darrick.wong@oracle.com, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: Initialize label array properly
Date: Fri, 30 Aug 2019 17:31:54 +1000 [thread overview]
Message-ID: <20190830073154.GO1119@dread.disaster.area> (raw)
In-Reply-To: <20190830053707.GA69101@LGEARND20B15>
On Fri, Aug 30, 2019 at 02:37:07PM +0900, Austin Kim wrote:
> In case kernel stack variable is not initialized properly,
> there is a risk of kernel information disclosure.
>
> So, initialize 'char label[]' array with null characters.
Can you describe the information disclosure vector here? I can't see
any, mostly because this is the "set label" function and that
doesn't return anything to userspace.
We also zero the on-disk label before we copy the user label into
it, so I don't see that anything can leak onto disk, either...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2019-08-30 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 5:37 [PATCH] xfs: Initialize label array properly Austin Kim
2019-08-30 5:39 ` Darrick J. Wong
2019-08-30 14:53 ` Austin Kim
2019-08-30 7:31 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830073154.GO1119@dread.disaster.area \
--to=david@fromorbit.com \
--cc=austindh.kim@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox